1. 28 Jan, 2022 3 commits
    • Rob Swindell's avatar
    • Rob Swindell's avatar
      Add 'vdir' (virtual directory name) member to lib_t and dir_t · 51ab0a7f
      Rob Swindell authored
      This change is just for internal consistency and convenience right now: the lib_t.vdir is a "sanitized" copy of the lib's short name (spaces are converted to dots or underscores based on the logic that the FTP server used in dotname()) and the dir_t.vdir is just a pointer to the dir's code_suffix. No other permutations are made (e.g. lower-casing the strings). Although the virtual directory names of libraries will now appear in mixed case in the FTP server (previously, they were all lowercase), the directory names are actually treated case-insensitively, so it should not make any difference. If forced-lowercase is preferred for some reason, please speak up.
      This change leads the way to eventually, possibly, making these virtual path elements sysop-configurable. For now, it's just better to have a *copy* of the lib's short name that is appropriately modified to make a suitable directory name and have that vpath element available globally (to all servers and services) in a consistent manner.
      So Nelgin asked (about filebase access via http), what if the library short name has a space in it? The answer now is, the spaces are replaced with a '.' or '_' (if there's already dots in the name).
    • Rob Swindell's avatar
      Fix up the directory internal code suffix help text · 19fbeaea
      Rob Swindell authored
      ... more aligned with a sub-board's internal code help text.
  2. 27 Jan, 2022 4 commits
    • Rob Swindell's avatar
      Allow files to be removed from batch queues by number · 86e39e82
      Rob Swindell authored
      This fixes issue #328.
      The user actually *can* remove files from the batch queues in v3.19b, but you have to type the filenames which is not obvious from the prompt which implies you need to type the file index position (e.g. '1' for the first file in the queue). In all Synchronet versions prior, you could only remove by number (and not by name).
      The fix is to allow either the number or the name of the file to be entered at the RemoveWhich prompt and the file is removed from the queue successfully.
      Thanks Ragnarok!
    • Rob Swindell's avatar
      Set default options.backup_level value (10) · 85fe6b47
      Rob Swindell authored
      Fixes issue #327.
      Also remove some old obsolete comments.
      Increment the REVISION value manually (no more CVS keywords).
    • Rob Swindell's avatar
      Fix default program section selection · 0deb94c7
      Rob Swindell authored
      Hitting [Enter] is supposed to select the current/default program
      section. Instead, it was quitting. This was apparently broken as
      part of the xtrn_sec.js refactor a year or so ago by/with mlong.
    • Rob Swindell's avatar
      Ignore VDD WriteFile() failures if the child process has terminated · 9445866c
      Rob Swindell authored
      If the child process (e.g. door game) has terminated, don't log errors if/when WriteFile() to the mailslot fails. This would be expected as the mailslot is created/owen-by sbbsexec.dll which would also terminate along with the process, thus closing the mailslot. 
      Hopefully resolves the errors reported by DesotoFireflite (VALHALLA).
  3. 26 Jan, 2022 4 commits
  4. 25 Jan, 2022 3 commits
  5. 23 Jan, 2022 12 commits
  6. 22 Jan, 2022 7 commits
    • Rob Swindell's avatar
      Add the 'O' (post using real name) restriction flag. · 927a1494
      Rob Swindell authored
      Oh, QWKnet nodes ('Q' restricted accounts) are impacted by this restriction
      since the poster's name isn't taken from the user account anyway.
    • Rob Swindell's avatar
      Handle duplicate names and aliases better · 55be2129
      Rob Swindell authored
      So some cute user (mine@demon.com) created a new user account on Vertrauen with the alias and real name of "Rob Swindell". Funny.
      Now, duplicate user aliases are already and always forbidden (even those that just vaguely match an existing alias) - everyone expects those to be unique. And we already forbid new user real names to match an existing user alias (check_name() enforces this and we use that when checking new user real names too), however, nothing prevented a new user account's alias from matching another existing user's real name. And this is a problem:
      1. This new/fake user could post a message or send an email/netmail and it would appear to possibly come from the other/original user (we do have options to send mail and post messages using real names)
      2. Received email for real names is supported and if enabled, this second account could be used to intercept mail for the original/first account if it was receiving mail for the original/real user's real name.
      So disallowing a new user's real name to match an existing alias fixes one problem. 
      However, systems *can* be configured to allow duplicate real names (which is convenient for QWKnet accounts, for example) and so we needed another solution for that problem: meet the 'O' restriction. This restriction flag will prevent a user account from posting messages no sub-boards that require real names. New user accounts that have a duplicate real name (the same as another user account's real name), will automatically be assigned the 'O' restriction flag. Systems that don't allow duplicate real names wouldn't have this issue in the first place.
      Scripts that allow the creation of new user accounts might need some updating to match this security logic.
    • Rob Swindell's avatar
      Call can_user_post() rather than manual checks · 9ae0448c
      Rob Swindell authored
      Eliminate some redundant code. Use the userdat lib function provided for this purpose.
    • Rob Swindell's avatar
      Remove some commented-out code · cac09153
      Rob Swindell authored
      Posting restrictions are handled one QWK-message at a time (and have been for a long time). No actual change here.
    • Rob Swindell's avatar
      Fix "Username already taken." validation error (could not happen) · 21b8b2c2
      Rob Swindell authored
      The system.check_name() check *also* verifies that the username is not
      already taken, so we must perform the matchuser() check first in order
      to get the appropriate error message here when trying to use an alias
      (username) that's already taken.
    • Rob Swindell's avatar
      Fix issue that prevent "-syslog" option from being used (on *nix) · c6fde03f
      Rob Swindell authored
      Fixed a couple sprintf() buffer overflow warnings/issues.
    • Rob Swindell's avatar
  7. 20 Jan, 2022 4 commits
  8. 19 Jan, 2022 3 commits