GitLab

Added an "All Servers" option.
Fixed the "Telnet server" (now "Terminal Server") to set the correct/modern semaphore file.
Simplified the implementation of this function.

Using the xtrn program section internal code protects against renumbering upon
configuration changes (inserting/removing program sections).
At Nelgin's suggestion/request.

Error objects are much easier to trace back to the offending line of code.
This was a pretty automated search/replace, so in some cases, it's a
commented-out instance that was changed. I did not convert *all* the load/*.js
files.

So you can do stuff (*like this*).

Also, we don't need to heavily scrutinize the closing tag when we come upon it because we already determined it was valid before we accepted the opening tag/character.

This appears to go back to a change Deuce made in 2004 (rev 1.41) where ANSI, COLOR, RIP and WIP user terminal settings were always cleared when logging in via RLogin.

I happened to notice that manually enabling iCE color support wasn't working when logging in via RLogin (the iCE color flag would be cleared every login, but worked fine when logging in via Telnet). Upon investigation, I found that *all* user's manual terminal settings were cleared for either RLogin or SSH logins (copy/pasted bug). So... stop doing that. The method of dynamic terminal capability detection/checking has changed since 2004, so we should not need to mess with the user's misc flags.

The reported problem (by John "Jay" Crutti) was:
If autodetection of the terminal is used from the defaults menu I get stuck on the prompt to hit my Delete key because on the BBS, it keeps showing me login statistics every time I hit my delete key. 

Add/use new K_CTRLKEYS mode to stop inkey() from handling/eating control-keys (e.g. Ctrl-T) when asking user to hit backspace during defaults->terminal settings.

Allow PETSCII_DELETE (Ctrl-T) as a valid option when asking for the backspace/delete key and set the PETSCII flag in the autoterm variable if hit by the user.

Defaults to "Off" ("No") and can be set per-sub-board to either:
- "Yes" parse/apply markup style to displayed message text while still displaying the markup tags
- "Hide" parse/apply markup style to displayed message text and hide (don't display) the markup tags
- "No", treat marked-up messages the same as any other message text, same as before.

The supported Markup tags at this time are:
#bold text#
/Italicized text/
_underlined text_
#inverse text#

Now, ANSI-BBS terminals (and Synchronet) do not support the concept of italic or underlined text (at least, not yet) - so those styles become combinations of the blink and high-intensity attributes which can be used to choose alternate fonts and this works well.

These 4 styles were chosen to be compatible with GoldEd's "Style Codes", though GoldEd is actually very configurable in its support of these tags/codes and its possible we're not 100% compatible. For example, GoldEd (and SemPoint) both support the combining of tags/codes to created combinations of styled text - Synchronet does not (this is consistent with Mozilla/Thunderbird's "Structured Text").

Multiple words can be styled with a single set of tags, but the first and last word must be delimited by white-space (this is not consistent with Markdown).

Multiple lines can be styled with a single set of tags, but not multiple paragraphs (this is consistent with Markdown).

The rules I chose were to minimize false positives but maintain some interoperability with GoldEd and Thunderbird with a familiar/common tag syntax.

Don't display the new network's domain if it's not defined.

Don't let ANSI terminal control sequence, e.g. from 1337 FILE_ID.DIZs, leak into file descriptions.

1. You can't include % specifiers in the string passed to system.exec()
   - this is just a wrapper for system(), it doesn't recongize Synchronet
     command-line specifiers.
   - so I just prepend the exec_dir for Win32, leave off for *nix.
   - it appears this wasn't tested since that command-line would not work.

2. Added 'j' option to unzip. We don't want the extraction of infopacks with
   sub-directories to be creating sub-directories under our ctrl dir.
   We should consider extracting to a temp dir instead of the ctrl dir if
   we don't have absolute control over what's being extracted from downloaded
   zip files. This could be dangerous if we're not extremely careful.

Just in case the sysop chose not to specify SYMLINK=1.
As reported by Dan_C via IRC, thanks.

A function/method to strip all ANSI terminal control sequences from a string.

Improvements to init fidonet. Add and update network list. Add ability to download infopack (for manual .NA extraction). Ask for and save tic and packet passwords. Handle domains.

add tqwnet to init tickit

See merge request sbbs/sbbs!19

This reverts commit d167733c.

This reverts commit 00e33392.

This reverts commit 11a8733a.

This reverts commit c3d93342.

Created a contributing file to address what seems to be the most common reasons for rejected merge requests.

This work-around shouldn't be necessary, but at least on my Linux/Samba setup, when GitLab sends out notification emails to subscribers and creates 4+ simultaneous SMTP connections and sends email messages, sometimes (often) it ends up with a lock-timeout on the mail base. The file locking should handle the contention fine, but somehow I end up in scenarios where savemsg() takes 30 seconds to complete (the configured SMB lock-timeout is 30 seconds, likely not a coincidence) - and this causes other clients to timeout trying to lock the base. Just use a sharead-mutex here instead as a work-around. The wait time is indefinite, might want to consider using a timed-wait instead.

Confirm with user before adding someone to twitlist

See merge request sbbs/sbbs!16

The default terminal columns (still 0/auto) can be overridden with the 'L' command from the user defaults menu. 

Also increased maximum manual terminal rows setting from 99 to 999 - this involved moving the record in user.dat, though the old record value is auto-migrated.

This is useful for detecting blank records.