GitLab

There were 2 bug identified by issue #230:
- the "Fwd:" prefix being added to the message subject was being treated as a filename. I first thought to just remove this subject tag, but then thought it best to just ignore obviously invalid filenames in the subject in the first place.

- when forwarding files to a netmail address, the 'to' extension (user number) is 0, so the file will be in the data/file/####.out directory of the sender instead.

We have 4 places (at least) where the message subjects are parsed and only one of those places currently supports quoted filenames (e.g. with spaces in them) and some of the others (e.g. QWK) don't support multiple filenames at all. That should be fixed.

The various __GNUC__ macros are defined in other compilers and
indicate support for a C language standard and can't be used to
detect if gcc the compiler is being used.

The service clients count is now a protected int, so deal. On Windows, this was resulting in the "total" and "served" values logged as 4294967295.

Even though https://docs.microsoft.com/en-us/cpp/preprocessor/predefined-macros?view=msvc-160 says they define it for C compiles, apparently they don't bother for C++. <shrug>

Apparently GNU forgot to include stdatomic.h in GCC 4.8.
For Altere and his CentOS 7 system.

Caught by Coverity - ftell[o] can return negative.

to mimic the behavior of the Win32 API function of the same name.

This function is the fastest file-copy method (or should be), but does not have any progress indication.

Caught by Coverity.

Appear to have been possible (to crash) by using a malformed text.dat file.

Nobody's checking the return values anyway.

Caught by GCC.

Caught by Coverity.

Check return value from read().

Mostly in error-paths.

Add the "two or three lines" that Deuce said were needed to restore this functionality.

Also got rid of some now unnecessary (void) protected_*int* return value ignoring warning-suppressors.

for better errors/warnings from the compiler when misued.

Interesting, this is how this code worked back in 2005, but was changed without a good description of why:
http://cvs.synchro.net/cgi-bin/viewcvs.cgi/src/sbbs3/xmodem.c?r1=1.15&r2=1.16

This addresses the anonymous SyncTERM bug report:
https://sourceforge.net/p/syncterm/tickets/46/

Thanks, whoever that was. :-)

Fixes last commit, which could cause infinite hangs on certain requests.

Should fix #223
Introduced in d56ba01f which likely fixed some stuff on the wiki.

Issue introduced in previous commit to this file. The name arg(s) comes before the address arg(s).

If the destination point node is not a linked node (does not exist in sbbsecho.ini), but the boss node is linked, automatically route to the boss node. The log entries look like this when this happens:
"Routing packet (%s) to boss-node %s"
"Routing NetMail (%s) to boss-node %s"

For poindexter FORTRAN (REALITY) - test results appreciated.

Incremented SBBSecho version to 3.13.

Previously, any DNS blacklist-exempt email addresses (in ctrl/dnsbl_exempt.cfg) had to be used in the mail-envelope (the "MAIL FROM:" address) - that doesn't work for all senders that use re-mailers or whatever where you end-up with some *bounce* address as the envelope-sender.

So now, clear the DNSBL results when the From header field is parsed and the sender was in fact an exempt sender. Note: the Subject line will still contain the SPAM tag if the subject was parsed first (came earlier in the message header). May need to address this limitation in the future if it turns out to be a problem (!).

Lowercase the [smtp|smtps]spy.txt log file.

protected_*_adjust() only adjusts now.

Deal with the resulting warnings (using (void)).
Deal with the incorrect integer to protected_int* assignment in services.c
(just don't support server.clients property reading in service scripts).

Also, the strcpy()->SAFECOPY() change in ftpsrvr.c was wrong, caught
by GCC warning - oops.