GitLab

There were 2 bug identified by issue #230:
- the "Fwd:" prefix being added to the message subject was being treated as a filename. I first thought to just remove this subject tag, but then thought it best to just ignore obviously invalid filenames in the subject in the first place.

- when forwarding files to a netmail address, the 'to' extension (user number) is 0, so the file will be in the data/file/####.out directory of the sender instead.

We have 4 places (at least) where the message subjects are parsed and only one of those places currently supports quoted filenames (e.g. with spaces in them) and some of the others (e.g. QWK) don't support multiple filenames at all. That should be fixed.

The service clients count is now a protected int, so deal. On Windows, this was resulting in the "total" and "served" values logged as 4294967295.

Caught by Coverity - ftell[o] can return negative.

This function is the fastest file-copy method (or should be), but does not have any progress indication.

Caught by Coverity.

Appear to have been possible (to crash) by using a malformed text.dat file.

Nobody's checking the return values anyway.

Caught by GCC.

Caught by Coverity.

Check return value from read().

Mostly in error-paths.

Add the "two or three lines" that Deuce said were needed to restore this functionality.

Also got rid of some now unnecessary (void) protected_*int* return value ignoring warning-suppressors.

Interesting, this is how this code worked back in 2005, but was changed without a good description of why:
http://cvs.synchro.net/cgi-bin/viewcvs.cgi/src/sbbs3/xmodem.c?r1=1.15&r2=1.16

This addresses the anonymous SyncTERM bug report:
https://sourceforge.net/p/syncterm/tickets/46/

Thanks, whoever that was. :-)

Fixes last commit, which could cause infinite hangs on certain requests.

Should fix #223
Introduced in d56ba01f which likely fixed some stuff on the wiki.

Issue introduced in previous commit to this file. The name arg(s) comes before the address arg(s).

If the destination point node is not a linked node (does not exist in sbbsecho.ini), but the boss node is linked, automatically route to the boss node. The log entries look like this when this happens:
"Routing packet (%s) to boss-node %s"
"Routing NetMail (%s) to boss-node %s"

For poindexter FORTRAN (REALITY) - test results appreciated.

Incremented SBBSecho version to 3.13.

Previously, any DNS blacklist-exempt email addresses (in ctrl/dnsbl_exempt.cfg) had to be used in the mail-envelope (the "MAIL FROM:" address) - that doesn't work for all senders that use re-mailers or whatever where you end-up with some *bounce* address as the envelope-sender.

So now, clear the DNSBL results when the From header field is parsed and the sender was in fact an exempt sender. Note: the Subject line will still contain the SPAM tag if the subject was parsed first (came earlier in the message header). May need to address this limitation in the future if it turns out to be a problem (!).

Lowercase the [smtp|smtps]spy.txt log file.

protected_*_adjust() only adjusts now.

Deal with the resulting warnings (using (void)).
Deal with the incorrect integer to protected_int* assignment in services.c
(just don't support server.clients property reading in service scripts).

Also, the strcpy()->SAFECOPY() change in ftpsrvr.c was wrong, caught
by GCC warning - oops.

Also, fix things that incorrectly reach into the protected_*_t to
incorrectly access values.

Previously, 403 was only returned if they existed, and 404 if they
didn't.

No need to get time() here since it's never checked.

Resolves CID 174292

Have free_paragraphs() explicitly allow paragraphs to be NULL and
have everything use the fail_return which now free()s ret.

Previously, more than 999 arguments would overrun a buffer and break
things.

Fixes CID 33313

Are you tired of getting TLS-related error log messages that you can't do anything about? e.g.
web  0139 TLS ERROR 'Received TLS alert message: Unexpected message' (-15) setting session active

The new sbbs.ini [web] TLSErrorLevel option (defaults to 0 / "Emergency") allows the sysop to set a cap (maximum severity) on TLS-related log messages in the web server (e.g. TLSErrorLevel=Warning).