GitLab

Good catch Coverity (CID 330974).

This won't impact Synchronet as it has a separate signal handling
thread, but we still need to behave properly for processes that
don't.  I'm also saying that ENOMEM does not indicate a disconnection,
though it may be better to pretend it was disconnected...

(not delete) from the end of the sorted list of files (normally, 0).
Created an sbbs_t::delfiles() wrapper which defaults to keep 0 files and also
generates a error.log message if any of the file-deletions fail.

output. Example:
File size        : 7,128,414 (6.8M) bytes

- FILE_AREA
- FILE_AREA_DESC
- FILE_LIB
- FILE_LIB_DESC
- FILE_LIB_NUM
- FILE_DIR
- FILE_DIR_DESC
- FILE_DIR_CODE
- FILE_DIR_NUM
- FILE_NAME
- FILE_DESC
- FILE_UPLOADER
- FILE_SIZE
- FILE_CREDITS
- FILE_TIME
- FILE_TIME_ULED
- FILE_TIME_DLED
- FILE_DATE
- FILE_DATE_ULED
- FILE_DAT_DLED
- FILE_TIMES_DLED
Fixed MSG_ATTR @-code (missing SPAM attribute)
New text.dat line: FileHdrDescSeparator, displayed between file detail display
(name, date, uploader, etc.) and extended description, if there is one. This
is used to execute showfileavatar.js.
New JS 'bbs' object properties:
- file_name
- file_description
- file_dir_number
- file_attr
- file_date
- file_credits
- file_uploader
- file_update_date
- file_download_date
- file_download_count
Inspiried by Lon Seidman's now infamous (but likely common) Synchronet sysop
blunder (removing a file rather than downloading it while demonstrating his BBS
on his youtube channel:
- New text.dat line: RemoveFileQ <- using this rather than the vague:
  AreYouSureQ, when prompting to remove a file
- The sysop command to remove files from the batch file flagging prompt has
  been changed from 'D' (delete) to 'R' (remove).
- The 'D' command from the batch file flagging prompt may now be used for
  immediate Download of any flagged file(s).
- When flagging files with '*', treat the same as '*.*'

other things to detect/display the actual filename (when different than
what's stored in the database).

time (e.g. "00:00:00"). Synchronet v3 has always forced this value to 0 since
it's inaccurate over TCP/IP with the current hard-coded "CPS" rate of 3000
(i.e. bytes-per-second).

longer (use lprintf(LOG_ERR,...) instead, which does).
Added sbbs_t::hacklog() for convenience.

inserting (long) typedefs to prevent warnings, but in the case of the JS File()
class, actually supporting file lengths > 32-bit.

by properly const-ifying the appropriate functions and variables.

Not yet tested on Win32

Remove time32str()

chars (probably overkill).
checkfname() now rejects filenames begining with a dash as a "suspicious
filename".

to get long filenames.

Each function that requires a temp string variable, now has its own "tmp" local variable.