GitLab

The internal line editor's quoting feature add some hard-coded strings ("Done" and "All") and the (L)ist key was hard-coded. Use the text.dat string (new and pre-existing) for these now.

Also, use the new sbbs_t *_key() methods for referencing the configured key bindings (via text.dat) for these common key-stroke commands.
Convert the text.dat strings for keys (e.g. YNQP) to uppercase always as well.

Found during review of previous commit.
Introduced as part of the new file base branch merge (commit fcf58640).

Environment variables are shared among all threads of a process (e.g. all nodes of a instance of sbbs), so this scheme of passing the uploaded filename and description to an external file tester (upload processor) via environment variables has always been fraught with the possibility of failure or flakiness in Synchronet v3. Since I very much doubt that any upload processor is actually using this scheme, just remove it. Upload processors can and should)use the sbbsfile.nam and sbbsfile.des text files created in the node directory instead.

It's anticipated that this will be used for JS-populated file metadata in JSON format in the future (and not just "archive contents" in .ini format).

Also, fix the double-free issue that was occurring when moving files with extended file descriptions (sbbs_t::movefile()). This was actually the primary problem I was fixing here, but noticed the metadata issue: metadata would not have been moved along with the other file info between bases.

Don't need no stinking pre/appended white-space in our filenames!

(prints the bad filename)
- also, checkfname() is going to do the file.can (trashcan) checking, so no need here

Inspired by Blocktronics (and other ANSI art group) packs' FILE_ID.DIZ/ANS files:
* Support (and prioritize) FILE_ID.ANS
* Convert ANSI color/attribute sequences in DIZ files to Ctrl-A equivalent (uses SAUCE width and ICE color, if specified)
* Don't treat DIZ as a series of lines, they're not always nowadays.
* New putmsg() mode: P_INDENT to print files indented by current column
* Display full (up to 64-char) filenames in lists when using 132+ column terminal.
* Use the Author, Group, and Title fields from the SAUCE if present/non-blank
* 2 new text.dat strings: 301 (FiAuthor) and 302 (FiGroup)
* Also fix bug with repeated Cost header field on bulk-uploaded files.

I know this'll break the *nix build (sauce.c dependency), but I'll fix that next.

Increase total extended description length from 1024 to 4000 characters. Perhaps this should be configurable?

I forget who it was that said they were still using this feature in v3.18, but here you go, it's working again (the /D and /U commands). I'm not migrating any file sender/recipient info from v3.18, so only files added after upgrading to this will be downloadable from the "user" directory (if you have one).

Something that I never implemented before but noticed is missing is the removal (or dereferencing) of user-to-user files that were sent from/to a user that is then deleted. So that's still a TODO item.

This won't impact Synchronet as it has a separate signal handling
thread, but we still need to behave properly for processes that
don't.  I'm also saying that ENOMEM does not indicate a disconnection,
though it may be better to pretend it was disconnected...

I'm fed-up with MSVC assertions in ctype functions (e.g. isdigit, isprint, isspace, etc.) when called with out-of-range (e.g. negative) values.

This problem only affects MSVC debug builds, but if you run them (like I do), these things are like little time bombs that can drive you crazy (knocking your board out of service).

The new macros names are bit more descriptive as well.

(defauls to enabled, for backward compatibility).
Added new autohang args to bbs.send_file() and bbs.receive_file() (default:true)
Added support for "description" argument to bbs.send_file() as well.

sbbs::lputs() will log the current user alias already, logline()->lputs() would
create log messages with the user alias twice.

set the "extended description" flag for all subsequently added files if one of
the files uploaded/added contained an embedded description (FILE_ID.DIZ)
causing garbage extended description display when viewing extended information
on files that did not in fact have an embedded description.

was never used. This was intended to be a method for internationalization,
letting the sysop change which key is used as the uiniversal "quit" key.
This commit replaces most of the uses of the hard-coded 'Q' for quit wtih the
3rd charcter in the text.dat YNQP string. Some hard-coded menus still have the
'Q' key hard-coded and will need to be addressed later. The text.h YN index
macro was changed to YNQP and the JS text index variable name will change
as well.

all exported functions and data types using a 32-bit time_t (time32_t).
(part 2 of 2)

longer (use lprintf(LOG_ERR,...) instead, which does).
Added sbbs_t::hacklog() for convenience.

of configured upload requirements) and exceed the "max files" settings per dir.
Also, directory operators now always have upload permissions.

32-bit file size limitation.

inserting (long) typedefs to prevent warnings, but in the case of the JS File()
class, actually supporting file lengths > 32-bit.

Added HOST and IP keywords to allow restricted access/privileges to/for
specific remote hostnames or IP addresses (wildcards allowed).
All string-argument type ARS keywords (e.g. SHELL, PROT, etc.) now support .can
style wildcards.
The current remote client is now used for protocol, host, and IP ARS checking,
when available, so this requires passing the client pointer around (which
explains why so many files are touched by this change) and takes care of a
long standing to-do item (the user's 'modem' value was used for the PROT
value checking, which was not always correct).

Constified the arguments.
Created exascii_to_ascii_char().
Created ctrl_a_to_ascii_char().
strip_ctrl() and prep_file_desc() now takes 2 args.
strip_ctrl(), strip_exascii() and prep_file_desc() now strdup() the input
string and if the dest arg is NULL, returns the allocated and modified copy.
sbbs_t::bputs() now handles ^AZ.
Change Ctrl-A code message network exporting:
1. ^AL, ^A<, ^A[, and ^A] are always translated to ASCII equivalents.
2. ^AZ will terminate the message body prematurely if found.
3. Ex-ASCII (CP437) chars will be translated to ASCII equivalents (rather than
'*') for "ASCII Only" subs.
For import, don't allow Ctrl-AP or Ctrl-AL.
For SBBSecho:
Added support for specifying a link's address on the command-line (e.g. for
use with -h).
Mail server now strips Ctrl-A codes from message bodies for sending via POP3
or SMTP.

changed FileNotThere text.dat entry to FileDoesNotExist which displays the file
path.
Now check if the directory exists before checking the available disk space
before allowing file uploads and report the correct error (using
DirectoryDoesNotExist) if the directory is missing (a common mistake).
Overhaul viewfilecontents() - wow, I can't wait to re-write all of this moldy
filebase code!

equivalent of Baja SEND_FILE_VIA and RECEIVE_FILE_VIA.

and receive_file() - so str_cmds.js may now support ;GET and ;PUT.

credits, and minutes - basically wrappers for adjustuserrec().

(rather than "No description given") if the real filename is different than
the one in the database (e.g. it's a long filename).

so configured in SCFG->System->New User Values->Question Toggles.

sysop or uploads dir) if the file was in the dir's database, but not on disk.
Cosmetic change: display unpadded filename in error strings.

used.