GitLab

A couple of stragglers here, the isalnum() call caught by an MSVC exception.

xp_inet_pton() now sets the socket errno value, doing as instructed by the TODO.

Rename the portable inet_pton() to xp_inet_pton() and define a wrapper macro (for all Widows builds) to use it instead of inet_pton() as not all supported Windows systems (e.g. WinXP) have an inet_pton() implementation.

This allows the HAProxy mod to be re-enabled by default without preventing executing on WinXP.

Sorry guys. :(

This one should build even on Win32.

Needed by MinGW32... we'll see if MSVC needs it as well soon.

Socket error descriptions on Windows can be quite long (e.g. > 128 chars) and
include punctuation, so include at the end of logged socket error messages.

If FormatMessage() fails on Windows (in socket_strerror()) return the
GetLastError() value in the error description.

Use Microsoft magic to "ignore regular line breaks in the message definition text." of socket error strings on Windows:
strips the embedded line-feeds from the socket error description.

that support large file offsets (e.g. 64-bit Linux).
Considered returning ssize_t (like sendfile does), but opted for off_t. Could
be convinced otherwise.

descriptions in bind failure error messages in a cross-platform
(i.e. WinSock-compatible) manner.

address (family and address value, ignoring ports and other fields).

failed login attempt client IP addresses on Windows.

(only impacts active FTP transfers via IPv6).

Specifically, if select(),  getsockopt(), or connect() fails, return
ERROR_VALUE instead of SOCKET_ERROR.

Found by Coverity since we never checked the return value of getsockopt()

Win32 make connect() failure an exceptional condition.

is, obviously, named WSAAddressToStringA() or WSAAddressToStringU().

options.

on an unsupported version of Windows like Win32S or Win98 or whatever.

I have no idea why we do this.

Fix inet_addrtop() for Win32.

is what defines socklen_t, so we need to undefine our copy before including
that header.

from a generic struct sockaddr.

Add a xpms_add_list() for adding a str_list_t full of host[:port] definitions
for when reading a str_list_t from the INI file of interfaces to listen on.