GitLab

The various __GNUC__ macros are defined in other compilers and
indicate support for a C language standard and can't be used to
detect if gcc the compiler is being used.

Even though https://docs.microsoft.com/en-us/cpp/preprocessor/predefined-macros?view=msvc-160 says they define it for C compiles, apparently they don't bother for C++. <shrug>

Apparently GNU forgot to include stdatomic.h in GCC 4.8.
For Altere and his CentOS 7 system.

Nobody's checking the return values anyway.

for better errors/warnings from the compiler when misued.

protected_*_adjust() only adjusts now.

Deal with the resulting warnings (using (void)).
Deal with the incorrect integer to protected_int* assignment in services.c
(just don't support server.clients property reading in service scripts).

Also, the strcpy()->SAFECOPY() change in ftpsrvr.c was wrong, caught
by GCC warning - oops.

Also, fix things that incorrectly reach into the protected_*_t to
incorrectly access values.

This reverts commit e1e034cc.

Didn't work for .cpp files:
stdatomic.h:40:9: error: ‘_Atomic’ does not name a type
typedef _Atomic _Bool atomic_bool

InterlockedCompareExchange() expects a long*, not a uint32_t*.

Most of the copyright years in the source code were misleading (the date of
most recent publish was actually later) and all were unnecessary. I've been
removing copyright years piecemeal, for a long time, but I decided it was time
to just perform a bulk search and (mostly) replace. In some cases, I left
old copyright years on files that either are not used (and soon to be removed)
or obsolete and unlikely to ever be touched again (e.g. Win9x FOSSIL VXD). Some
of the runtime binaries still contain copyright years and those were updated to
2018.

current protected-interger value.

(interlocked/atomic) integer variables.

(or at least unusable) pthread_t which is fine on FreeBSD as it's a pointer.

I've left the recursive stuff in with an #ifdef __linux__ wrapper though
it's a Bad Thing.

After I talk to DigitalMan, this may all get ripped out in favour of proper
pthread mutex usage, but I'm not sure why he wants recursive mutexes.

This may need tweaking for FreeBSD or OS-X support.

defined).
Use recursive mutex for mutex-protected linked-lists on *nix (the only kind of
mutex/critical-section on Windows).

_np means "Non-portable"  :-)

SetThreadName(char *c)
Which sets a thread name for debugging purposes.