Commits (18)
-
Rob Swindell authored
Hopefully not introducing any bugs in the process.
0c441424 -
Rob Swindell authored5771d524
-
Rob Swindell authoredc0373038
-
Rob Swindell authored
Make Coverity happy.
454a05f0 -
Rob Swindell authored
Reverted the SAFECOPY() NULL source-pointer magic "(null)" string thing as that caused a different Coverity issue. Explicitly check for NULL at the call-sites instead.
9344a7d8 -
Rob Swindell authored
The Synchronet FTP server has (since 2001) disallowed PORT/EPRT/LPRT commands with a "reserved" port number (i.e. < 1024) as recommended by RFC2577 and when attempted, would log a "SUSPECTED FTP BOUNCE HACK ATTEMPT" in the data/hack.log file. However, as Karloch (HISPAMSX) pointed out recently, an FTP Bounce Attack to other TCP ports was still possible (and detected/reported by some security scans as a potential vulnerability). So, reject all PORT/EPRT/LPRT commands that specify an IP address other than that used for the control TCP connection unless the sysop specifically enables the new "ALLOW_BOUNCE" option flag (in the [ftp] section of sbbs.ini) and the user is an authenticated non-guest/anonymous user. And as before, log the attempt as a suspected hack attempt. This change also removes the "Directory File Access" checkbox from the Synchronet Control Panel for Windows as that feature is "going away" soon (or at least, it won't be an FTP-specific option/feature if it remains).
ebece39d -
Rob Swindell authoredfaac4653
-
Rob Swindell authored
... instead of the JSON parse exception as reported via IRC: <matjam> !finger ?bbs:Stupendous BBS@vert.synchro.net result: SyntaxError: JSON.parse
a8768797 -
Michael Long authored0a58ca90
-
Rob Swindell authored
3rd party external doors - exitilus, jibben, jns See merge request !110
90d98dfa -
Deucе authored5379321a
-
Rob Swindell authored91531c3e
-
Rob Swindell authored35d07d85
-
Rob Swindell authored9d05c7f8
-
Rob Swindell authored55a5f22c
-
Rob Swindell authored
Deuce said to just delete it. <shrug>
b911ee03 -
Rob Swindell authoreda6efc1be
Showing