Skip to content
GitLab
Projects
Groups
Snippets
Help
Loading...
Help
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
Synchronet
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
128
Issues
128
List
Boards
Labels
Service Desk
Milestones
Merge Requests
1
Merge Requests
1
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Operations
Operations
Metrics
Environments
Packages & Registries
Packages & Registries
Package Registry
Container Registry
Analytics
Analytics
CI / CD
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Main
Synchronet
Compare Revisions
a6efc1beffc68abb0f64e23e2cfddc83563c9074...4e9ff218de9f9656b2451ae5b168cc281b7acb12
Source
4e9ff218de9f9656b2451ae5b168cc281b7acb12
Select Git revision
...
Target
a6efc1beffc68abb0f64e23e2cfddc83563c9074
Select Git revision
Compare
Commits (1)
Fix apparent memory leak in js_listening_socket_constructor()
· 4e9ff218
Rob Swindell
authored
Feb 15, 2021
The socket set allocated by xpms_create() was never freed. Found by Coverity.
4e9ff218
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
3 additions
and
3 deletions
+3
-3
src/sbbs3/js_socket.c
src/sbbs3/js_socket.c
+3
-3
No files found.
src/sbbs3/js_socket.c
View file @
4e9ff218
...
...
@@ -396,8 +396,9 @@ static void js_finalize_socket(JSContext *cx, JSObject *obj)
do_js_close
(
p
,
true
);
if
(
p
->
hostname
)
free
(
p
->
hostname
);
if
(
!
p
->
external
)
free
(
p
->
set
);
free
(
p
->
hostname
);
free
(
p
);
JS_SetPrivate
(
cx
,
obj
,
NULL
);
...
...
@@ -2817,7 +2818,6 @@ js_listening_socket_constructor(JSContext *cx, uintN argc, jsval *arglist)
JS_ReportError
(
cx
,
"Unable to create socket set"
);
goto
fail
;
}
// A for Digitman: "Nothing." -- DigitalMan (via Mumble)
if
(
obj
==
NULL
)
{
JSVALUE_TO_MSTRING
(
cx
,
argv
[
0
],
interface
,
NULL
);
HANDLE_PENDING
(
cx
,
interface
);
...
...