BinkIT: M_EOB logged as warning when peer does not send M_GOT
Observations:
- Transfers complete successfully and files are received/applied as expected
- This behavior has been reproduced across multiple systems, including:
- Mystic (various versions: A47, A48, A49)
- Internet Rex
Other systems (e.g., binkd, binkIT) do not exhibit this behavior
The issue appears to be caused by the remote system not sending M_GOT prior to M_EOB, rather than a failure in BinkIT
Example log excerpt:
Impact:
- No functional impact (files are transferred and processed correctly)
- However, the log entry is flagged as a warning/error, which may be misleading and imply a failed or incomplete transfer Suggestion
If the transfer completes successfully and the file is handled correctly, consider:
- Downgrading this condition from a warning/error to a notice/debug message, or
- Adding additional context to clarify that the issue is due to non-compliant peer behavior rather than a transfer failure
Edited by xbit ops