Skip to content

IRC IPs sometimes sent a in x.x.x.x format not decimal IPs

[02:35] -eotlbbs.synchro.net- *** Client -- Client connecting: mrnelgin (nelgin@47.186.47.220) [47.186.47.220] {10} [02:35] -eotlbbs.synchro.net- *** Global -- from services.synchro.net: WARNING: invalid IP address `47.186.47.220' for new nick mrnelgin

I first noticed this while investigating another issue:

This is correct:

[15:16] -eotlbbs.synchro.net- *** RemoteClient -- NICK deubiest ~kuofinger@51.68.79.223 reality.synchro.net 860114911 :paerl [15:16] -eotlbbs.synchro.net- *** RemoteClient -- NICK pluamly ~greiwt@tor-exit-63.for-privacy.net reality.synchro.net 3118228799 :braukest

This is not: [13:30] -eotlbbs.synchro.net- *** RemoteClient -- NICK luca50__ ~andchat54@host-87-0-152-9.retail.telecomitalia.it veleno.synchro.net 87.0.152.9 :AndChat542100 [13:30] -eotlbbs.synchro.net- *** Global -- from services.synchro.net: WARNING: invalid IP address 87.0.152.9' for new nick luca50__ [13:34] -eotlbbs.synchro.net- *** RemoteClient -- NICK LinksGetter ~irclib@vert.synchro.net vert.synchro.net 71.95.196.34 :irclib.js-1.24 [13:34] -eotlbbs.synchro.net- *** Global -- from services.synchro.net: WARNING: invalid IP address 71.95.196.34' for new nick LinksGetter

Server<>Server code needs to be audited to make sure decimal IP addresses are passed when expected.

Edited by Nigel Reed