Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
Synchronet Synchronet
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 186
    • Issues 186
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge requests 2
    • Merge requests 2
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Metrics
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Main
  • SynchronetSynchronet
  • Merge requests
  • !128

Merged
Created Dec 11, 2021 by Eric Oulashin@nightfoxDeveloper

SlyEdit v1.75: Refactored the quote selection menu and cross-post selection

  • Overview 0
  • Commits 1
  • Pipelines 1
  • Changes 6

SlyEdit v1.75: Refactored the quote selection menu and cross-post selection menus to use DDLightbarMenu instead of SlyEdit's own lightbar code. This allowed the elimination of most of the rest of SlyEdit's own lightbar code, reducing the size of SlyEdit.js by about 40Kb. It also provides some consistency in behavior by using a common menu component.

Also, to support some additional required behaviors by SlyEdit, added the following 'event' functions to the DDLightbarMenu class: ValidateSelectItem(pItemRetval): For validating that the user can select an item. Takes the item's return value, and returns a bool to indicate whether the item can be selected.

OnItemSelect(pItemRetval, pSelected): A function that is called when an item is being selected (or de-selected, when multi-select is enabled). The parameters are the item's return value and a boolean to indicate whether the item was selected or de-selected.

Also, added an explicit DoKeyDown() function to DDLightbarMenu to support scrolling the menu down when desired (special case for SlyEdit's quote selection window).

Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Source branch: slyedit_175_crosspost_and_quote_menu_refactor_ddlightbarmenu