Skip to content

GitLab

Fix file list sorting by date, need to use the index not the header 

When loadfiles() calls sortfiles(), only the file's index records have been
read in, so trying to sort on any header field won't work.

This bug wasn't observable when sorting by date ascending, since that's the
natural index order of the files already (order imported/added), only
observed when sorting by date descending (newest at the top).
14 jobs for master in 9 minutes and 51 seconds (queued for 11 seconds)
67d3c3e2
No related merge requests found.
Status Job ID Name Coverage
  Build
failed #34269
FreeBSD
jsdoor-freebsd

00:00:05

passed #34270
Linux
jsdoor-linux

00:06:37

passed #34272
FreeBSD
jsdoor-windows

00:01:57

failed #34264
FreeBSD
sbbs-freebsd

00:00:07

passed #34259
Linux
sbbs-linux

00:09:47

passed #34262
Windows
sbbs-windows

00:05:00

passed #34271
FreeBSD
sexpots-freebsd

00:00:11

passed #34260
Linux
sexpots-linux

00:00:22

passed #34263
Windows
sexpots-windows

00:00:33

passed #34267
FreeBSD
syncdraw-freebsd

00:00:25

passed #34268
Linux
syncdraw-linux

00:01:05

passed #34265
FreeBSD
syncterm-freebsd

00:01:02

passed #34261
Linux
syncterm-linux

00:02:52

passed #34266
FreeBSD
syncterm-windows

00:01:46

 
Name Stage Failure
failed
jsdoor-freebsd Build 
checking for python2.6... no
checking for python2.5... no
checking for python... no
configure: error: python was not found in $PATH
gmake[1]: *** [GNUmakefile:77: ../build/../../src/../3rdp/clang.freebsd.amd64.release/mozjs/lib/libmozjs185-1.0.a] Error 1
gmake[1]: Leaving directory '/var/tmp/gitlab_runner/builds/TkL89aUh/3/main/sbbs/3rdp/build'
gmake: *** [/var/tmp/gitlab_runner/builds/TkL89aUh/3/main/sbbs/src/sbbs3/../build/Common.gmake:524: js] Error 2
Cleaning up file based variables
ERROR: Job failed: exit status 1
failed
sbbs-freebsd Build 
checking for python2.6... no
checking for python2.5... no
checking for python... no
configure: error: python was not found in $PATH
gmake[1]: *** [GNUmakefile:77: ../build/../../src/../3rdp/clang.freebsd.amd64.release/mozjs/lib/libmozjs185-1.0.a] Error 1
gmake[1]: Leaving directory '/var/tmp/gitlab_runner/builds/TkL89aUh/0/main/sbbs/3rdp/build'
gmake: *** [/var/tmp/gitlab_runner/builds/TkL89aUh/0/main/sbbs/src/sbbs3/../build/Common.gmake:524: js] Error 2
Cleaning up file based variables
ERROR: Job failed: exit status 1