Skip to content
Snippets Groups Projects
Commit 2df371fe authored by Rob Swindell's avatar Rob Swindell :speech_balloon:
Browse files

Manual terminal settings were cleared when logging in via SSH or RLogin

This appears to go back to a change Deuce made in 2004 (rev 1.41) where ANSI, COLOR, RIP and WIP user terminal settings were always cleared when logging in via RLogin.

I happened to notice that manually enabling iCE color support wasn't working when logging in via RLogin (the iCE color flag would be cleared every login, but worked fine when logging in via Telnet). Upon investigation, I found that *all* user's manual terminal settings were cleared for either RLogin or SSH logins (copy/pasted bug). So... stop doing that. The method of dynamic terminal capability detection/checking has changed since 2004, so we should not need to mess with the user's misc flags.
parent 0eaa6bbf
No related branches found
No related tags found
1 merge request!463MRC mods by Codefenix (2024-10-20)
Pipeline #479 passed
...@@ -109,7 +109,6 @@ bool sbbs_t::answer() ...@@ -109,7 +109,6 @@ bool sbbs_t::answer()
useron.number=matchuser(&cfg, rlogin_name, /* sysop_alias: */FALSE); useron.number=matchuser(&cfg, rlogin_name, /* sysop_alias: */FALSE);
if(useron.number) { if(useron.number) {
getuserdat(&cfg,&useron); getuserdat(&cfg,&useron);
useron.misc&=~TERM_FLAGS;
SAFEPRINTF(path,"%srlogin.cfg",cfg.ctrl_dir); SAFEPRINTF(path,"%srlogin.cfg",cfg.ctrl_dir);
if(!findstr(client.addr,path)) { if(!findstr(client.addr,path)) {
SAFECOPY(tmp, rlogin_pass); SAFECOPY(tmp, rlogin_pass);
...@@ -213,7 +212,6 @@ bool sbbs_t::answer() ...@@ -213,7 +212,6 @@ bool sbbs_t::answer()
useron.number=matchuser(&cfg, rlogin_name, /* sysop_alias: */FALSE); useron.number=matchuser(&cfg, rlogin_name, /* sysop_alias: */FALSE);
if(useron.number) { if(useron.number) {
getuserdat(&cfg,&useron); getuserdat(&cfg,&useron);
useron.misc&=~TERM_FLAGS;
for(i=0;i<3 && online;i++) { for(i=0;i<3 && online;i++) {
if(stricmp(tmp,useron.pass)) { if(stricmp(tmp,useron.pass)) {
if(cfg.sys_misc&SM_ECHO_PW) if(cfg.sys_misc&SM_ECHO_PW)
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment