Skip to content
Snippets Groups Projects
Select Git revision
  • dd_msg_area_chooser_coloring_fix_and_separator_char_fix
  • dailybuild_linux-x64
  • dailybuild_win32
  • master default protected
  • sqlite
  • rip_abstraction
  • dailybuild_macos-armv8
  • dd_file_lister_filanem_in_desc_color
  • mode7
  • dd_msg_reader_are_you_there_warning_improvement
  • c23-playing
  • syncterm-1.3
  • syncterm-1.2
  • test-build
  • hide_remote_connection_with_telgate
  • 638-can-t-control-c-during-a-file-search
  • add_body_to_pager_email
  • mingw32-build
  • cryptlib-3.4.7
  • ree/mastermind
  • sbbs320d
  • syncterm-1.6
  • syncterm-1.5
  • syncterm-1.4
  • sbbs320b
  • syncterm-1.3
  • syncterm-1.2
  • syncterm-1.2rc6
  • syncterm-1.2rc5
  • push
  • syncterm-1.2rc4
  • syncterm-1.2rc2
  • syncterm-1.2rc1
  • sbbs319b
  • sbbs318b
  • goodbuild_linux-x64_Sep-01-2020
  • goodbuild_win32_Sep-01-2020
  • goodbuild_linux-x64_Aug-31-2020
  • goodbuild_win32_Aug-31-2020
  • goodbuild_win32_Aug-30-2020
40 results

putmsg.cpp

  • Rob Swindell's avatar
    0178043e
    Correctly center lines of text that contain @-codes, after @center@ · 0178043e
    Rob Swindell authored
    @-codes weren't expanded before the text length calculation, so the centering
    logic (offset in the user's terminal screen) would usually be incorrect as
    pointed out by Nelgin in #synchronet when we were discussing the |C @-code
    modifier (which is to center an @-code value in a field, not the screen).
    
    This issue was a known limitation of the fix to issue #418 (commit 8987150b)
    but now that we have the expand_atcodes() function (hooray!), this is an
    easily solvable problem.
    
    Note: we're now calling center() withOUT the 'msg' parameter set to true,
    which means the @center@ code goes back to the previous (to issue #418 fix)
    behavior of just using bputs() for the centered text (we don't need the
    recursive call to pustmsg() to support @-codes any longer). This was the only
    reason that center() grew the optional 'msg' parameter so we likely can remove
    that option/feature at some date.
    0178043e
    History
    Correctly center lines of text that contain @-codes, after @center@
    Rob Swindell authored
    @-codes weren't expanded before the text length calculation, so the centering
    logic (offset in the user's terminal screen) would usually be incorrect as
    pointed out by Nelgin in #synchronet when we were discussing the |C @-code
    modifier (which is to center an @-code value in a field, not the screen).
    
    This issue was a known limitation of the fix to issue #418 (commit 8987150b)
    but now that we have the expand_atcodes() function (hooray!), this is an
    easily solvable problem.
    
    Note: we're now calling center() withOUT the 'msg' parameter set to true,
    which means the @center@ code goes back to the previous (to issue #418 fix)
    behavior of just using bputs() for the centered text (we don't need the
    recursive call to pustmsg() to support @-codes any longer). This was the only
    reason that center() grew the optional 'msg' parameter so we likely can remove
    that option/feature at some date.