Skip to content
Snippets Groups Projects
Select Git revision
  • dailybuild_linux-x64
  • dailybuild_win32
  • master default protected
  • sqlite
  • rip_abstraction
  • dailybuild_macos-armv8
  • dd_file_lister_filanem_in_desc_color
  • mode7
  • dd_msg_reader_are_you_there_warning_improvement
  • c23-playing
  • syncterm-1.3
  • syncterm-1.2
  • test-build
  • hide_remote_connection_with_telgate
  • 638-can-t-control-c-during-a-file-search
  • add_body_to_pager_email
  • mingw32-build
  • cryptlib-3.4.7
  • ree/mastermind
  • new_user_dat
  • sbbs320d
  • syncterm-1.6
  • syncterm-1.5
  • syncterm-1.4
  • sbbs320b
  • syncterm-1.3
  • syncterm-1.2
  • syncterm-1.2rc6
  • syncterm-1.2rc5
  • push
  • syncterm-1.2rc4
  • syncterm-1.2rc2
  • syncterm-1.2rc1
  • sbbs319b
  • sbbs318b
  • goodbuild_linux-x64_Sep-01-2020
  • goodbuild_win32_Sep-01-2020
  • goodbuild_linux-x64_Aug-31-2020
  • goodbuild_win32_Aug-31-2020
  • goodbuild_win32_Aug-30-2020
40 results

js_file.c

  • Rob Swindell's avatar
    10562789
    Eliminte weird gcc (12.2) warning in release build (only) · 10562789
    Rob Swindell authored
    Increasing size of mode[] element by 2 bytes eliminated these GCC warnings
    that seem like false-positives to me:
    
    sbbs.h:194:48: warning: writing 1 byte into a region of size 0 [-Wstringop-overflow=]
      194 |                                 (ret)[JSSTSpos]=(char)JSSTSstrval[JSSTSpos]; \
          |                                 ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~
    js_file.c:225:25: note: in expansion of macro ‘JSSTRING_TO_STRBUF’
      225 |                         JSSTRING_TO_STRBUF(cx, str, p->mode, sizeof(p->mode), NULL);
          |                         ^~~~~~~~~~~~~~~~~~
    js_file.c:42:17: note: at offset 5 into destination object ‘mode’ of size 5
       42 |         char    mode[5];
          |                 ^~~~
    
    Similar use of JSSTRING_TO_STRBUF in other files (js_console.cpp, js_archive.c)
    (with larger target buffers) does not trigger the same warnings.
    10562789
    History
    Eliminte weird gcc (12.2) warning in release build (only)
    Rob Swindell authored
    Increasing size of mode[] element by 2 bytes eliminated these GCC warnings
    that seem like false-positives to me:
    
    sbbs.h:194:48: warning: writing 1 byte into a region of size 0 [-Wstringop-overflow=]
      194 |                                 (ret)[JSSTSpos]=(char)JSSTSstrval[JSSTSpos]; \
          |                                 ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~
    js_file.c:225:25: note: in expansion of macro ‘JSSTRING_TO_STRBUF’
      225 |                         JSSTRING_TO_STRBUF(cx, str, p->mode, sizeof(p->mode), NULL);
          |                         ^~~~~~~~~~~~~~~~~~
    js_file.c:42:17: note: at offset 5 into destination object ‘mode’ of size 5
       42 |         char    mode[5];
          |                 ^~~~
    
    Similar use of JSSTRING_TO_STRBUF in other files (js_console.cpp, js_archive.c)
    (with larger target buffers) does not trigger the same warnings.