Skip to content
Snippets Groups Projects
Select Git revision
  • dailybuild_linux-x64
  • dailybuild_win32
  • master default protected
  • sqlite
  • rip_abstraction
  • dailybuild_macos-armv8
  • dd_file_lister_filanem_in_desc_color
  • mode7
  • dd_msg_reader_are_you_there_warning_improvement
  • c23-playing
  • syncterm-1.3
  • syncterm-1.2
  • test-build
  • hide_remote_connection_with_telgate
  • 638-can-t-control-c-during-a-file-search
  • add_body_to_pager_email
  • mingw32-build
  • cryptlib-3.4.7
  • ree/mastermind
  • new_user_dat
  • sbbs320d
  • syncterm-1.6
  • syncterm-1.5
  • syncterm-1.4
  • sbbs320b
  • syncterm-1.3
  • syncterm-1.2
  • syncterm-1.2rc6
  • syncterm-1.2rc5
  • push
  • syncterm-1.2rc4
  • syncterm-1.2rc2
  • syncterm-1.2rc1
  • sbbs319b
  • sbbs318b
  • goodbuild_linux-x64_Sep-01-2020
  • goodbuild_win32_Sep-01-2020
  • goodbuild_linux-x64_Aug-31-2020
  • goodbuild_win32_Aug-31-2020
  • goodbuild_win32_Aug-30-2020
40 results

js_msgbase.c

Blame
    • rswindell's avatar
      562f5e6d
      Bug: a get_mg_header() followed by a put_msg_header() would add a header field · 562f5e6d
      rswindell authored 
      (SMTPREVERSEPATH a.k.a. "reverse_path") if it didn't already have one.
That's because smb_getmsghdr() will point the msg.reverse_path convenience
pointer to the from_net_addr if there was no explicit reverse-path (e.g. RFC822's
"return-path" header field). This could manifest itself in *any* change to a
message header via JS failing with an "illegal header length increase" error if
the added header field just happen to put the total header length over the
allocation threshold of the pre-existing msg header.

Fix: only model a msg header "reverse_path" property if the header field
actually existed (not based on the SMBLIB convenience pointer).
When the expand_fields option is used, the old behavior remains but expanded
headers cannot be written back to the base, so no harm there.

Reported by Coz in #synchronet from failed runs of scrubmsgs.js. Thanks!
      562f5e6d
      History
      Bug: a get_mg_header() followed by a put_msg_header() would add a header field
      rswindell authored 
      (SMTPREVERSEPATH a.k.a. "reverse_path") if it didn't already have one.
That's because smb_getmsghdr() will point the msg.reverse_path convenience
pointer to the from_net_addr if there was no explicit reverse-path (e.g. RFC822's
"return-path" header field). This could manifest itself in *any* change to a
message header via JS failing with an "illegal header length increase" error if
the added header field just happen to put the total header length over the
allocation threshold of the pre-existing msg header.

Fix: only model a msg header "reverse_path" property if the header field
actually existed (not based on the SMBLIB convenience pointer).
When the expand_fields option is used, the old behavior remains but expanded
headers cannot be written back to the base, so no harm there.

Reported by Coz in #synchronet from failed runs of scrubmsgs.js. Thanks!