Skip to content
Snippets Groups Projects
Select Git revision
  • master default protected
  • dailybuild_linux-x64
  • dailybuild_win32
  • sqlite
  • rip_abstraction
  • dailybuild_macos-armv8
  • dd_file_lister_filanem_in_desc_color
  • mode7
  • dd_msg_reader_are_you_there_warning_improvement
  • c23-playing
  • syncterm-1.3
  • syncterm-1.2
  • test-build
  • hide_remote_connection_with_telgate
  • 638-can-t-control-c-during-a-file-search
  • add_body_to_pager_email
  • mingw32-build
  • cryptlib-3.4.7
  • ree/mastermind
  • new_user_dat
  • sbbs320d
  • syncterm-1.6
  • syncterm-1.5
  • syncterm-1.4
  • sbbs320b
  • syncterm-1.3
  • syncterm-1.2
  • syncterm-1.2rc6
  • syncterm-1.2rc5
  • push
  • syncterm-1.2rc4
  • syncterm-1.2rc2
  • syncterm-1.2rc1
  • sbbs319b
  • sbbs318b
  • goodbuild_linux-x64_Sep-01-2020
  • goodbuild_win32_Sep-01-2020
  • goodbuild_linux-x64_Aug-31-2020
  • goodbuild_win32_Aug-31-2020
  • goodbuild_win32_Aug-30-2020
40 results

prntfile.cpp

  • Rob Swindell's avatar
    b656e19f
    Report error when menu() can't find a display file and P_NOERROR not used · b656e19f
    Rob Swindell authored
    This issue was introduced in commit d02fc1a2 (3 years ago), where menu() would
    silenty fail (just return false) if no display file matching the supported
    menu/display file types/extensions could be found.
    
    Previous to commit d02fc1a2, we would log a NOTICE-level message and display
    a "File not found" message to the user (what sbbs_t::printfile() does), but
    since d02fc1a2, we no longer even call printfile() when the file doesn't
    exist, so no error was logged or message displayed to the user.
    
    Of course, when using the P_NOERROR mode flag, silent failure is expected and
    that's still what happens in that case.
    b656e19f
    History
    Report error when menu() can't find a display file and P_NOERROR not used
    Rob Swindell authored
    This issue was introduced in commit d02fc1a2 (3 years ago), where menu() would
    silenty fail (just return false) if no display file matching the supported
    menu/display file types/extensions could be found.
    
    Previous to commit d02fc1a2, we would log a NOTICE-level message and display
    a "File not found" message to the user (what sbbs_t::printfile() does), but
    since d02fc1a2, we no longer even call printfile() when the file doesn't
    exist, so no error was logged or message displayed to the user.
    
    Of course, when using the P_NOERROR mode flag, silent failure is expected and
    that's still what happens in that case.