Skip to content
Snippets Groups Projects
Commit 0dbd3f06 authored by Rob Swindell's avatar Rob Swindell :speech_balloon:
Browse files

Fix some apparent memory leaks when using file's auxdata

Nobody's really using this auxdata yet, besides echicken, so no impact for
others.
parent ba877839
Branches
Tags
No related merge requests found
...@@ -1226,6 +1226,7 @@ js_add_file(JSContext *cx, uintN argc, jsval *arglist) ...@@ -1226,6 +1226,7 @@ js_add_file(JSContext *cx, uintN argc, jsval *arglist)
JS_RESUMEREQUEST(cx, rc); JS_RESUMEREQUEST(cx, rc);
smb_freefilemem(&file); smb_freefilemem(&file);
free(extdesc); free(extdesc);
free(auxdata);
return JS_TRUE; return JS_TRUE;
} }
...@@ -1305,7 +1306,8 @@ js_update_file(JSContext *cx, uintN argc, jsval *arglist) ...@@ -1305,7 +1306,8 @@ js_update_file(JSContext *cx, uintN argc, jsval *arglist)
} else { } else {
if(file.extdesc != NULL) if(file.extdesc != NULL)
truncsp(file.extdesc); truncsp(file.extdesc);
if(!readd_always && strcmp(extdesc ? extdesc : "", file.extdesc ? file.extdesc : "") == 0) if(!readd_always && strcmp(extdesc ? extdesc : "", file.extdesc ? file.extdesc : "") == 0
&& strcmp(auxdata ? auxdata : "", file.auxdata ? file.auxdata : "") == 0)
p->smb_result = smb_putfile(&p->smb, &file); p->smb_result = smb_putfile(&p->smb, &file);
else { else {
if((p->smb_result = smb_removefile(&p->smb, &file)) == SMB_SUCCESS) { if((p->smb_result = smb_removefile(&p->smb, &file)) == SMB_SUCCESS) {
...@@ -1320,6 +1322,7 @@ js_update_file(JSContext *cx, uintN argc, jsval *arglist) ...@@ -1320,6 +1322,7 @@ js_update_file(JSContext *cx, uintN argc, jsval *arglist)
smb_freefilemem(&file); smb_freefilemem(&file);
free(filename); free(filename);
free(extdesc); free(extdesc);
free(auxdata);
return result; return result;
} }
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment