Skip to content
Snippets Groups Projects
Commit 261324a6 authored by Rob Swindell's avatar Rob Swindell :speech_balloon:
Browse files

Merge branch 'dd_msg_reader_scrolling_read_input_timeout_fix' into 'master'

DDMsgReader bug fix: In the scrolling message reader interface, it now exits on user input timeout (as it should). This should fix issue #844, reported by Keyop

Closes #844

See merge request !483
parents cfdaf02e 095951c6
No related branches found
No related tags found
1 merge request!483DDMsgReader bug fix: In the scrolling message reader interface, it now exits on user input timeout (as it should). This should fix issue #844, reported by Keyop
Pipeline #7402 passed
...@@ -205,6 +205,9 @@ ...@@ -205,6 +205,9 @@
* 2024-12-04 Eric Oulashin Version 1.96g * 2024-12-04 Eric Oulashin Version 1.96g
* Bug fix: For indexed newscan without snap-to-new, go back to * Bug fix: For indexed newscan without snap-to-new, go back to
* remembering the user's previously selected sub-board * remembering the user's previously selected sub-board
* 2024-12-18 Eric Oulashin Version 1.96h
* When reading messages with the scrolling interface, pay attention
* to user input timeout via a check of the last user input.
*/ */
   
"use strict"; "use strict";
...@@ -312,8 +315,8 @@ var hexdump = load('hexdump_lib.js'); ...@@ -312,8 +315,8 @@ var hexdump = load('hexdump_lib.js');
   
   
// Reader version information // Reader version information
var READER_VERSION = "1.96g"; var READER_VERSION = "1.96h";
var READER_DATE = "2024-12-04"; var READER_DATE = "2024-12-18";
   
// Keyboard key codes for displaying on the screen // Keyboard key codes for displaying on the screen
var UP_ARROW = ascii(24); var UP_ARROW = ascii(24);
...@@ -6990,6 +6993,10 @@ function DigDistMsgReader_ReadMessageEnhanced_Scrollable(msgHeader, allowChgMsgA ...@@ -6990,6 +6993,10 @@ function DigDistMsgReader_ReadMessageEnhanced_Scrollable(msgHeader, allowChgMsgA
retObj.nextAction = ACTION_QUIT; retObj.nextAction = ACTION_QUIT;
continueOn = false; continueOn = false;
break; break;
case "": // User input timeout
retObj.nextAction = ACTION_QUIT;
continueOn = false;
break;
default: default:
writeMessage = false; writeMessage = false;
break; break;
...@@ -20194,6 +20201,7 @@ function scrollTextLines(pTxtLines, pTopLineIdx, pTxtAttrib, pWriteTxtLines, pTo ...@@ -20194,6 +20201,7 @@ function scrollTextLines(pTxtLines, pTopLineIdx, pTxtAttrib, pWriteTxtLines, pTo
writeTxtLines = true; writeTxtLines = true;
} }
break; break;
case "": // User input timeout
default: default:
continueOn = false; continueOn = false;
break; break;
...@@ -5,7 +5,7 @@ ...@@ -5,7 +5,7 @@
// If you have DDMsgReader in a directory other than xtrn/DDMsgReader, then the changes to // If you have DDMsgReader in a directory other than xtrn/DDMsgReader, then the changes to
// DDMsgReader.cfg will be saved in that directory (assuming you're running ddmr_cfg.js from // DDMsgReader.cfg will be saved in that directory (assuming you're running ddmr_cfg.js from
// that same directory). // that same directory).
// Currently for DDMsgReader 1.96g. // Currently for DDMsgReader 1.96h.
// //
// If you're running DDMsgReader from xtrn/DDMsgReader (the standard location) and you want // If you're running DDMsgReader from xtrn/DDMsgReader (the standard location) and you want
// to save the configuration file there (rather than sbbs/mods), you can use one of the // to save the configuration file there (rather than sbbs/mods), you can use one of the
...@@ -18,7 +18,7 @@ require("sbbsdefs.js", "P_NONE"); ...@@ -18,7 +18,7 @@ require("sbbsdefs.js", "P_NONE");
require("uifcdefs.js", "UIFC_INMSG"); require("uifcdefs.js", "UIFC_INMSG");
if (!uifc.init("DigDist. Message Reader 1.96g Configurator")) if (!uifc.init("DigDist. Message Reader 1.96h Configurator"))
{ {
print("Failed to initialize uifc"); print("Failed to initialize uifc");
exit(1); exit(1);
......
Digital Distortion Message Reader Digital Distortion Message Reader
Version 1.96g Version 1.96h
Release date: 2024-12-04 Release date: 2024-12-18
   
by by
   
......
...@@ -5,6 +5,9 @@ Revision History (change log) ...@@ -5,6 +5,9 @@ Revision History (change log)
============================= =============================
Version Date Description Version Date Description
------- ---- ----------- ------- ---- -----------
1.96h 2024-12-18 Bug fix: When reading messages with the scrolling
interface, it now exits from user input timeout as it
should.
1.96g 2024-12-04 Bug fix: For indexed newscan without snap-to-new, go back 1.96g 2024-12-04 Bug fix: For indexed newscan without snap-to-new, go back
to remembering the user's previously selected sub-board to remembering the user's previously selected sub-board
1.96f 2024-12-04 New user option & behavior: When selecting/toggling 1.96f 2024-12-04 New user option & behavior: When selecting/toggling
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment