Skip to content
Snippets Groups Projects
Commit 4192b404 authored by Rob Swindell's avatar Rob Swindell :speech_balloon:
Browse files

Remove startup->node_spysem, nobody's using it and it had a bad bug

This came about through the realization that the global 'sbbs' in main.cpp
can (and was/is) hiding some copy/pasta bugs.
parent 940d31ca
No related branches found
No related tags found
No related merge requests found
......@@ -2462,10 +2462,6 @@ void output_thread(void* arg)
if(startup->node_spybuf!=NULL
&& startup->node_spybuf[sbbs->cfg.node_num-1]!=NULL) {
RingBufWrite(startup->node_spybuf[sbbs->cfg.node_num-1],buf+bufbot,i);
/* Signal spy output semaphore? */
if(startup->node_spysem!=NULL
&& startup->node_spysem[sbbs->cfg.node_num-1]!=NULL)
sem_post(startup->node_spysem[sbbs->cfg.node_num-1]);
}
/* Spy on the user remotely */
if(spy_socket[sbbs->cfg.node_num-1]!=INVALID_SOCKET)
......@@ -3894,10 +3890,6 @@ void sbbs_t::spymsg(const char* msg)
if(startup->node_spybuf!=NULL
&& startup->node_spybuf[cfg.node_num-1]!=NULL) {
RingBufWrite(startup->node_spybuf[cfg.node_num-1],(uchar*)str,strlen(str));
/* Signal spy output semaphore? */
if(startup->node_spysem!=NULL
&& startup->node_spysem[sbbs->cfg.node_num-1]!=NULL)
sem_post(startup->node_spysem[sbbs->cfg.node_num-1]);
}
if(cfg.node_num && spy_socket[cfg.node_num-1]!=INVALID_SOCKET)
......
......@@ -101,7 +101,6 @@ typedef struct {
str_list_t ssh_interfaces;
RingBuf** node_spybuf; /* Spy output buffer (each node) */
RingBuf** node_inbuf; /* User input buffer (each node) */
sem_t** node_spysem; /* Spy output semaphore (each node) */
void* cbdata; /* Private data passed to callbacks */
void* event_cbdata; /* Private data passed to event_lputs callback */
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment