Fix filebase corruption caused by FileBase.renew()

echicken reported this problem: pretty severe filebase corruption as a result
of calling FileBase.renew(). The problem seemed pretty obvious (only loading
the file's index record), but I do think the underlying SMBLIB functions
should be more resilient to misuse and not corrupt the base. So, that's still
a TODO.

No existing scripts were using FileBase.renew(), so this problem has gone
unnoticed since SBBS v3.19.

src/sbbs3/js_filebase.c

@@ -1355,7 +1355,7 @@ js_renew_file(JSContext *cx, uintN argc, jsval *arglist)
 
 	rc=JS_SUSPENDREQUEST(cx);
 	file_t file;
-	if((p->smb_result = smb_loadfile(&p->smb, fname, &file, file_detail_index)) == SMB_SUCCESS) {
+	if((p->smb_result = smb_loadfile(&p->smb, fname, &file, file_detail_metadata)) == SMB_SUCCESS) {
 		char path[MAX_PATH + 1];
 		p->smb_result = smb_renewfile(&p->smb, &file, SMB_SELFPACK, getfilepath(scfg, &file, path));
 		smb_freefilemem(&file);