Snippets Groups Projects

Commit 581087f3 authored 4 years ago by Deucе

Work around broken sz

Some broken protocol drivers (like sz) don't send a YModem terminate
at the end of a batch (or maybe just after a single file?) so SyncTERM
ends up trying to fall back from G to CRC-16 to 8-bit before ending.

This detects when the last known file was received, and if the YModem
header that follows is not correct, aborts the transfer.

parent 2e1cedad

No related branches found

No related tags found

1 merge request!463MRC mods by Codefenix (2024-10-20)

Pipeline #1508 passed 4 years ago

Hide whitespace changes

Inline Side-by-side

Showing with 9 additions and 1 deletion

Rob Swindell @rswindell · 4 years ago

Owner

Just to clarify, "sz --ymodem" was sending the empty/termination block, but the server (SBBS) was flushing its output buffer before the block could be placed into the TCP transmit buffers (the rioctl(IOFB) call in download.cpp).

No change to SyncTERM should be needed to resolve this issue.

Just to clarify, "sz --ymodem" was sending the empty/termination block, but the server (SBBS) was flushing its output buffer before the block could be placed into the TCP transmit buffers (the rioctl(IOFB) call in download.cpp). No change to SyncTERM should be needed to resolve this issue.

Please register or to comment