Skip to content
Snippets Groups Projects
Commit 6a19711b authored by Rob Swindell's avatar Rob Swindell :speech_balloon:
Browse files

Bug-fix: erroneously filtering vote messages by age

This bug was introduced in commit 9c91d32a 2 years ago and would result
in votes and poll message being erroneously filtered. e.g.
!Filtering QWK message from (null) due to age: 19321 days

The filter criteria was either a zero-initialized msg or the previously
parsed/imported msg from the QWK or REP packet.

A solution for filtering vote/poll messages is needed, but this isn't it.
parent efc04997
No related branches found
No related tags found
No related merge requests found
......@@ -166,8 +166,6 @@ bool sbbs_t::unpack_qwk(char *packet,uint hubnum)
n=(uint)block[123]|(((uint)block[124])<<8); /* conference number */
if(blocks<2) {
if(block[0] == 'V' && blocks == 1 && voting != NULL) { /* VOTING DATA */
if(qwk_msg_filtered(&msg, ip_can, host_can, subject_can, twit_list))
continue;
if(!qwk_voting(&voting, l, NET_QWK, cfg.qhub[hubnum]->id, n, hubnum)) {
lprintf(LOG_WARNING, "QWK vote failure, offset %lu in %s", l, packet);
errors++;
......
......@@ -197,8 +197,6 @@ bool sbbs_t::unpack_rep(char* repfile)
long confnum = atol((char *)block+1);
if(blocks<2) {
if(block[0] == 'V' && blocks == 1 && voting != NULL) { /* VOTING DATA */
if(qwk_msg_filtered(&msg, ip_can, host_can, subject_can, twit_list))
continue;
if(!qwk_voting(&voting, l, (useron.rest&FLAG('Q')) ? NET_QWK : NET_NONE, /* QWKnet ID : */useron.alias, confnum)) {
lprintf(LOG_WARNING, "QWK vote failure, offset %ld of %s", l, getfname(msg_fname));
errors++;
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment