Fix some of the new Coverity warnings.

src/sbbs3/terminal.cpp

@@ -28,8 +28,6 @@ void Terminal::scroll_hotspots(unsigned count)
 		struct mouse_hotspot* spot = (struct mouse_hotspot*)node->data;
 		spot->y -= count;
 		spots++;
-		if (spot->y >= 0)
-			remain++;
 	}
 #ifdef _DEBUG
 	if (spots)

src/sbbs3/useredit.cpp

@@ -87,10 +87,8 @@ void sbbs_t::useredit(int usernumber)
 		        , (user.level > useron.level || !(cfg.sys_misc & SM_ECHO_PW)) ? "<hidden>" : user_pass
 		        );
 		bprintf(text[UeditRealNamePhone]
-		        , user.level > useron.level && console & CON_R_ECHO
-		    ? "XXXXXXXX" : user.name
-		        , user.level > useron.level && console & CON_R_ECHO
-		    ? "XXX-XXX-XXXX" : user.phone);
+		        , user.level > useron.level ? "XXXXXXXX" : user.name
+		        , user.level > useron.level ? "XXX-XXX-XXXX" : user.phone);
 		bprintf(text[UeditAddressBirthday]
 		        , user.address, getage(&cfg, user.birth), user.sex
 		        , format_birthdate(&cfg, user.birth, tmp, sizeof(tmp)));

src/sbbs3/xtrn.cpp

@@ -1618,7 +1618,7 @@ int sbbs_t::external(const char* cmdline, int mode, const char* startup_dir)
 	if ((mode & EX_STDIO) == EX_STDIO)  {
 		struct winsize winsize;
 		struct termios termio;
-		memset(&termio, 0, sizeof(term));
+		memset(&termio, 0, sizeof(termio));
 		cfsetispeed(&termio, B19200);
 		cfsetospeed(&termio, B19200);
 		if (mode & EX_BIN)