Commit 759d2788 authored by Rob Swindell's avatar Rob Swindell 💬
Browse files

The great DLLCALL purge of 2021

This macro has expanded to nothing for a while now and even before, the usage was misguided and unnecessary as explained in this video: https://www.youtube.com/watch?v=cjotPqQxxAY
parent 57981cf2
Pipeline #1830 passed with stage
in 10 minutes and 5 seconds
......@@ -73,7 +73,7 @@ char *faddrtoa(fidoaddr_t addr)
return(str);
}
char* DLLCALL strip_ctrl(char *str)
char* strip_ctrl(char *str)
{
char tmp[1024];
int i,j;
......
......@@ -100,7 +100,7 @@ uint sbbs_t::finduser(const char* instr, bool silent_failure)
/****************************************************************************/
/* Return date/time that the specified event should run next */
/****************************************************************************/
extern "C" time_t DLLCALL getnexteventtime(event_t* event)
extern "C" time_t getnexteventtime(event_t* event)
{
struct tm tm;
time_t t = time(NULL);
......@@ -143,7 +143,7 @@ extern "C" time_t DLLCALL getnexteventtime(event_t* event)
/* Return time of next forced timed event */
/* 'event' may be NULL */
/****************************************************************************/
extern "C" time_t DLLCALL getnextevent(scfg_t* cfg, event_t* event)
extern "C" time_t getnextevent(scfg_t* cfg, event_t* event)
{
int i;
time_t event_time=0;
......
......@@ -29,7 +29,7 @@ const char *mon[]={"Jan","Feb","Mar","Apr","May","Jun"
/****************************************************************************/
/* Converts a date string in format MM/DD/YY into unix time format */
/****************************************************************************/
time32_t DLLCALL dstrtounix(scfg_t* cfg, const char *instr)
time32_t dstrtounix(scfg_t* cfg, const char *instr)
{
const char* p;
const char* day;
......@@ -80,7 +80,7 @@ time32_t DLLCALL dstrtounix(scfg_t* cfg, const char *instr)
/****************************************************************************/
/* Converts unix time format (long - time_t) into a char str MM/DD/YY */
/****************************************************************************/
char* DLLCALL unixtodstr(scfg_t* cfg, time32_t t, char *str)
char* unixtodstr(scfg_t* cfg, time32_t t, char *str)
{
struct tm tm;
time_t unix_time=t;
......@@ -111,7 +111,7 @@ char* DLLCALL unixtodstr(scfg_t* cfg, time32_t t, char *str)
/****************************************************************************/
/* Takes the value 'sec' and makes a string the format HH:MM:SS */
/****************************************************************************/
char* DLLCALL sectostr(uint sec,char *str)
char* sectostr(uint sec,char *str)
{
uchar hour,min,sec2;
......@@ -123,7 +123,7 @@ char* DLLCALL sectostr(uint sec,char *str)
}
/* Returns a shortened version of "HH:MM:SS" formatted seconds value */
char* DLLCALL seconds_to_str(uint seconds, char* str)
char* seconds_to_str(uint seconds, char* str)
{
char* p = sectostr(seconds, str);
while(*p=='0' || *p==':')
......@@ -133,7 +133,7 @@ char* DLLCALL seconds_to_str(uint seconds, char* str)
/****************************************************************************/
/****************************************************************************/
char* DLLCALL hhmmtostr(scfg_t* cfg, struct tm* tm, char* str)
char* hhmmtostr(scfg_t* cfg, struct tm* tm, char* str)
{
if(cfg->sys_misc&SM_MILITARY)
sprintf(str,"%02d:%02d "
......@@ -149,7 +149,7 @@ char* DLLCALL hhmmtostr(scfg_t* cfg, struct tm* tm, char* str)
/* Generates a 24 character ASCII string that represents the time_t pointer */
/* Used as a replacement for ctime() */
/****************************************************************************/
char* DLLCALL timestr(scfg_t* cfg, time32_t t, char* str)
char* timestr(scfg_t* cfg, time32_t t, char* str)
{
char* mer;
uchar hour;
......
......@@ -559,7 +559,7 @@ int sockreadline(SOCKET socket, CRYPT_SESSION sess, char* buf, int len, time_t*
return(rd);
}
void DLLCALL ftp_terminate(void)
void ftp_terminate(void)
{
lprintf(LOG_INFO,"FTP Server terminate");
terminate_server=TRUE;
......@@ -4886,7 +4886,7 @@ static void cleanup(int code, int line)
startup->terminated(startup->cbdata,code);
}
const char* DLLCALL ftp_ver(void)
const char* ftp_ver(void)
{
static char ver[256];
char compiler[32];
......@@ -4908,7 +4908,7 @@ const char* DLLCALL ftp_ver(void)
return(ver);
}
void DLLCALL ftp_server(void* arg)
void ftp_server(void* arg)
{
char* p;
char path[MAX_PATH+1];
......
......@@ -26,7 +26,7 @@
/* If sent is non-zero, it returns the number of mail sent by usernumber */
/* If usernumber is 0, it returns all mail on the system */
/****************************************************************************/
int DLLCALL getmail(scfg_t* cfg, int usernumber, BOOL sent, int attr)
int getmail(scfg_t* cfg, int usernumber, BOOL sent, int attr)
{
char path[MAX_PATH+1];
int i=0;
......@@ -72,7 +72,7 @@ int DLLCALL getmail(scfg_t* cfg, int usernumber, BOOL sent, int attr)
/***************************/
/* Delete file attachments */
/***************************/
BOOL DLLCALL delfattach(scfg_t* cfg, smbmsg_t* msg)
BOOL delfattach(scfg_t* cfg, smbmsg_t* msg)
{
char dir[MAX_PATH+1];
char path[MAX_PATH+1];
......@@ -110,7 +110,7 @@ BOOL DLLCALL delfattach(scfg_t* cfg, smbmsg_t* msg)
/* of pointers to mail_t (message numbers and attributes) */
/* smb_open(&smb) must be called prior */
/****************************************************************************/
mail_t* DLLCALL loadmail(smb_t* smb, uint32_t* msgs, uint usernumber
mail_t* loadmail(smb_t* smb, uint32_t* msgs, uint usernumber
,int which, long mode)
{
ulong l=0;
......@@ -172,7 +172,7 @@ mail_t* DLLCALL loadmail(smb_t* smb, uint32_t* msgs, uint usernumber
return(mail);
}
void DLLCALL freemail(mail_t* mail)
void freemail(mail_t* mail)
{
if(mail!=NULL)
free(mail);
......
......@@ -27,7 +27,7 @@
/* Reads data from dsts.dab into stats structure */
/* If node is zero, reads from ctrl\dsts.dab, otherwise from each node */
/****************************************************************************/
BOOL DLLCALL getstats(scfg_t* cfg, char node, stats_t* stats)
BOOL getstats(scfg_t* cfg, char node, stats_t* stats)
{
char str[MAX_PATH+1];
int file;
......@@ -46,7 +46,7 @@ BOOL DLLCALL getstats(scfg_t* cfg, char node, stats_t* stats)
/****************************************************************************/
/* Returns the number of files in the directory 'dirnum' */
/****************************************************************************/
long DLLCALL getfiles(scfg_t* cfg, uint dirnum)
long getfiles(scfg_t* cfg, uint dirnum)
{
char path[MAX_PATH + 1];
off_t l;
......@@ -63,7 +63,7 @@ long DLLCALL getfiles(scfg_t* cfg, uint dirnum)
/****************************************************************************/
/* Returns total number of posts in a sub-board */
/****************************************************************************/
ulong DLLCALL getposts(scfg_t* cfg, uint subnum)
ulong getposts(scfg_t* cfg, uint subnum)
{
if(cfg->sub[subnum]->misc & SUB_NOVOTING) {
char path[MAX_PATH + 1];
......
......@@ -176,7 +176,7 @@ static JSClass js_client_class = {
,JS_FinalizeStub /* finalize */
};
JSObject* DLLCALL js_CreateClientObject(JSContext* cx, JSObject* parent
JSObject* js_CreateClientObject(JSContext* cx, JSObject* parent
,const char* name, client_t* client, SOCKET sock, CRYPT_CONTEXT session)
{
JSObject* obj;
......
......@@ -826,7 +826,7 @@ js_com_constructor(JSContext *cx, uintN argc, jsval *arglist)
return(JS_TRUE);
}
JSObject* DLLCALL js_CreateCOMClass(JSContext* cx, JSObject* parent)
JSObject* js_CreateCOMClass(JSContext* cx, JSObject* parent)
{
JSObject* comobj;
......@@ -841,7 +841,7 @@ JSObject* DLLCALL js_CreateCOMClass(JSContext* cx, JSObject* parent)
return(comobj);
}
JSObject* DLLCALL js_CreateCOMObject(JSContext* cx, JSObject* parent, const char *name, COM_HANDLE com)
JSObject* js_CreateCOMObject(JSContext* cx, JSObject* parent, const char *name, COM_HANDLE com)
{
JSObject* obj;
private_t* p;
......
......@@ -3046,7 +3046,7 @@ JSClass js_cryptcert_class = {
,js_finalize_cryptcert /* finalize */
};
JSObject* DLLCALL js_CreateCryptCertObject(JSContext* cx, CRYPT_CERTIFICATE cert)
JSObject* js_CreateCryptCertObject(JSContext* cx, CRYPT_CERTIFICATE cert)
{
JSObject *obj;
struct js_cryptcert_private_data *p;
......@@ -3180,7 +3180,7 @@ static char* cryptcert_format_prop_desc[] = {
};
#endif
JSObject* DLLCALL js_CreateCryptCertClass(JSContext* cx, JSObject* parent)
JSObject* js_CreateCryptCertClass(JSContext* cx, JSObject* parent)
{
JSObject* cksobj;
JSObject* constructor;
......
......@@ -934,7 +934,7 @@ JSClass js_cryptcon_class = {
,js_finalize_cryptcon /* finalize */
};
JSObject* DLLCALL js_CreateCryptconObject(JSContext* cx, CRYPT_CONTEXT ctx)
JSObject* js_CreateCryptconObject(JSContext* cx, CRYPT_CONTEXT ctx)
{
JSObject *obj;
struct js_cryptcon_private_data *p;
......@@ -1055,7 +1055,7 @@ static char* cryptcon_mode_prop_desc[] = {
};
#endif
JSObject* DLLCALL js_CreateCryptContextClass(JSContext* cx, JSObject* parent)
JSObject* js_CreateCryptContextClass(JSContext* cx, JSObject* parent)
{
JSObject* ccobj;
JSObject* constructor;
......
......@@ -518,7 +518,7 @@ static char* cryptkeyset_keyopt_prop_desc[] = {
};
#endif
JSObject* DLLCALL js_CreateCryptKeysetClass(JSContext* cx, JSObject* parent)
JSObject* js_CreateCryptKeysetClass(JSContext* cx, JSObject* parent)
{
JSObject* cksobj;
JSObject* constructor;
......
......@@ -3106,7 +3106,7 @@ js_file_constructor(JSContext *cx, uintN argc, jsval *arglist)
return(JS_TRUE);
}
JSObject* DLLCALL js_CreateFileClass(JSContext* cx, JSObject* parent)
JSObject* js_CreateFileClass(JSContext* cx, JSObject* parent)
{
JSObject* obj;
......@@ -3121,7 +3121,7 @@ JSObject* DLLCALL js_CreateFileClass(JSContext* cx, JSObject* parent)
return(obj);
}
JSObject* DLLCALL js_CreateFileObject(JSContext* cx, JSObject* parent, char *name, int fd, const char* mode)
JSObject* js_CreateFileObject(JSContext* cx, JSObject* parent, char *name, int fd, const char* mode)
{
JSObject* obj;
private_t* p;
......
......@@ -182,7 +182,7 @@ static JSClass js_dir_class = {
,js_file_area_finalize /* finalize */
};
JSBool DLLCALL js_file_area_resolve(JSContext* cx, JSObject* areaobj, jsid id)
JSBool js_file_area_resolve(JSContext* cx, JSObject* areaobj, jsid id)
{
char str[128];
char vpath[MAX_PATH+1];
......@@ -621,7 +621,7 @@ static JSClass js_file_area_class = {
,js_file_area_finalize /* finalize */
};
DLLEXPORT JSObject* DLLCALL js_CreateFileAreaObject(JSContext* cx, JSObject* parent, scfg_t* cfg
DLLEXPORT JSObject* js_CreateFileAreaObject(JSContext* cx, JSObject* parent, scfg_t* cfg
,user_t* user, client_t* client, char* html_index_file) {
JSObject* obj;
struct js_file_area_priv *p;
......
......@@ -1565,7 +1565,7 @@ static char* filebase_sort_prop_desc[] = {
};
#endif
JSObject* DLLCALL js_CreateFileBaseClass(JSContext* cx, JSObject* parent, scfg_t* cfg)
JSObject* js_CreateFileBaseClass(JSContext* cx, JSObject* parent, scfg_t* cfg)
{
JSObject* obj;
JSObject* constructor;
......
......@@ -48,7 +48,7 @@ enum {
,GLOB_PROP_SOCKET_ERRNO_STR
};
BOOL DLLCALL js_argc(JSContext *cx, uintN argc, uintN min)
BOOL js_argc(JSContext *cx, uintN argc, uintN min)
{
if(argc < min) {
JS_ReportError(cx, "Insufficient Arguments");
......@@ -5277,7 +5277,7 @@ JSClass js_global_class = {
,js_global_finalize /* finalize */
};
BOOL DLLCALL js_CreateGlobalObject(JSContext* cx, scfg_t* cfg, jsSyncMethodSpec* methods, js_startup_t* startup, JSObject**glob)
BOOL js_CreateGlobalObject(JSContext* cx, scfg_t* cfg, jsSyncMethodSpec* methods, js_startup_t* startup, JSObject**glob)
{
global_private_t* p;
JSRuntime* rt;
......
......@@ -240,7 +240,7 @@ static char* prop_desc[] = {
};
#endif
JSBool DLLCALL
JSBool
js_CommonOperationCallback(JSContext *cx, js_callback_t* cb)
{
js_callback_t *top_cb;
......@@ -1480,7 +1480,7 @@ static JSClass js_internal_class = {
,JS_FinalizeStub /* finalize */
};
void DLLCALL js_EvalOnExit(JSContext *cx, JSObject *obj, js_callback_t* cb)
void js_EvalOnExit(JSContext *cx, JSObject *obj, js_callback_t* cb)
{
char* p;
jsval rval;
......@@ -1545,7 +1545,7 @@ void DLLCALL js_EvalOnExit(JSContext *cx, JSObject *obj, js_callback_t* cb)
cb->auto_terminate = TRUE;
}
JSObject* DLLCALL js_CreateInternalJsObject(JSContext* cx, JSObject* parent, js_callback_t* cb, js_startup_t* startup)
JSObject* js_CreateInternalJsObject(JSContext* cx, JSObject* parent, js_callback_t* cb, js_startup_t* startup)
{
JSObject* obj;
......@@ -1600,7 +1600,7 @@ void msvc_invalid_parameter_handler(const wchar_t* expression,
}
#endif
void DLLCALL js_PrepareToExecute(JSContext *cx, JSObject *obj, const char *filename, const char* startup_dir, JSObject *scope)
void js_PrepareToExecute(JSContext *cx, JSObject *obj, const char *filename, const char* startup_dir, JSObject *scope)
{
JSString* str;
jsval val;
......
......@@ -93,7 +93,7 @@ struct js_msg_area_priv {
uint subnum;
};
BOOL DLLCALL js_CreateMsgAreaProperties(JSContext* cx, scfg_t* cfg, JSObject* subobj, uint subnum)
BOOL js_CreateMsgAreaProperties(JSContext* cx, scfg_t* cfg, JSObject* subobj, uint subnum)
{
char str[128];
JSString* js_str;
......@@ -379,7 +379,7 @@ static JSClass js_sub_class = {
,js_msg_area_finalize /* finalize */
};
JSBool DLLCALL js_msg_area_resolve(JSContext* cx, JSObject* areaobj, jsid id)
JSBool js_msg_area_resolve(JSContext* cx, JSObject* areaobj, jsid id)
{
JSObject* allgrps;
JSObject* allsubs;
......@@ -638,7 +638,7 @@ static JSClass js_msg_area_class = {
,js_msg_area_finalize /* finalize */
};
JSObject* DLLCALL js_CreateMsgAreaObject(JSContext* cx, JSObject* parent, scfg_t* cfg
JSObject* js_CreateMsgAreaObject(JSContext* cx, JSObject* parent, scfg_t* cfg
,user_t* user, client_t* client, subscan_t* subscan)
{
JSObject* obj;
......
......@@ -1000,7 +1000,7 @@ err:
}
/* obj *may* have been previously returned from get_msg_header() */
BOOL DLLCALL js_ParseMsgHeaderObject(JSContext* cx, JSObject* obj, smbmsg_t* msg)
BOOL js_ParseMsgHeaderObject(JSContext* cx, JSObject* obj, smbmsg_t* msg)
{
privatemsg_t* p;
......@@ -1015,7 +1015,7 @@ BOOL DLLCALL js_ParseMsgHeaderObject(JSContext* cx, JSObject* obj, smbmsg_t* msg
}
/* obj must've been previously returned from get_msg_header() */
BOOL DLLCALL js_GetMsgHeaderObjectPrivates(JSContext* cx, JSObject* obj, smb_t** smb, smbmsg_t** msg, post_t** post)
BOOL js_GetMsgHeaderObjectPrivates(JSContext* cx, JSObject* obj, smb_t** smb, smbmsg_t** msg, post_t** post)
{
privatemsg_t* p;
......@@ -3434,7 +3434,7 @@ static struct JSPropertySpec js_msgbase_static_properties[] = {
{0}
};
JSObject* DLLCALL js_CreateMsgBaseClass(JSContext* cx, JSObject* parent, scfg_t* cfg)
JSObject* js_CreateMsgBaseClass(JSContext* cx, JSObject* parent, scfg_t* cfg)
{
JSObject* obj;
JSObject* constructor;
......
......@@ -483,7 +483,7 @@ js_queue_constructor(JSContext *cx, uintN argc, jsval *arglist)
return(JS_TRUE);
}
JSObject* DLLCALL js_CreateQueueClass(JSContext* cx, JSObject* parent)
JSObject* js_CreateQueueClass(JSContext* cx, JSObject* parent)
{
JSObject* obj;
......@@ -499,7 +499,7 @@ JSObject* DLLCALL js_CreateQueueClass(JSContext* cx, JSObject* parent)
return(obj);
}
JSObject* DLLCALL js_CreateQueueObject(JSContext* cx, JSObject* parent, char *name, msg_queue_t* q)
JSObject* js_CreateQueueObject(JSContext* cx, JSObject* parent, char *name, msg_queue_t* q)
{
JSObject* obj;
......
......@@ -25,7 +25,7 @@ static void trigger_thread(void *args)
}
}
JSRuntime * DLLCALL jsrt_GetNew(int maxbytes, unsigned long timeout, const char *filename, long line)
JSRuntime * jsrt_GetNew(int maxbytes, unsigned long timeout, const char *filename, long line)
{
JSRuntime *ret;
......@@ -42,7 +42,7 @@ JSRuntime * DLLCALL jsrt_GetNew(int maxbytes, unsigned long timeout, const char
return ret;
}
void DLLCALL jsrt_Release(JSRuntime *rt)
void jsrt_Release(JSRuntime *rt)
{
list_node_t *node;
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment