free() the string returned by strList(Remove|Pop) to avoid memory leaks.

src/syncterm/bbslist.c

@@ -637,11 +637,14 @@ void read_list(char *listpath, struct bbslist **list, struct bbslist *defaults,
 		bbses=iniGetSectionList(inilines,NULL);
 		while((bbsname=strListRemove(&bbses,0))!=NULL) {
 			if(!list_name_check(list, bbsname, NULL, FALSE)) {
-				if((list[*i]=(struct bbslist *)malloc(sizeof(struct bbslist)))==NULL)
+				if((list[*i]=(struct bbslist *)malloc(sizeof(struct bbslist)))==NULL) {
+					free(bbsname);
 					break;
+				}
 				read_item(inilines,list[*i],bbsname,*i,type);
 				(*i)++;
 			}
+			free(bbsname);
 		}
 		strListFree(&bbses);
 		strListFree(&inilines);

src/syncterm/fonts.c

@@ -56,6 +56,7 @@ void save_font_files(struct font_files *fonts)
 	/* TODO: Remove all sections... we don't *NEED* to do this */
 	while((fontid=strListPop(&fontnames))!=NULL) {
 		iniRemoveSection(&ini_file, fontid);
+		free(fontid);
 	}
 
 	if(fonts != NULL) {
@@ -99,12 +100,15 @@ struct font_files *read_font_files(int *count)
 	}
 	fonts=iniReadSectionList(inifile, "Font:");
 	while((fontid=strListPop(&fonts))!=NULL) {
-		if(!fontid[5])
+		if(!fontid[5]) {
+			free(fontid);
 			continue;
+		}
 		(*count)++;
 		tmp=(struct font_files *)realloc(ret, sizeof(struct font_files)*(*count+1));
 		if(tmp==NULL) {
 			count--;
+			free(fontid);
 			continue;
 		}
 		ret=tmp;
@@ -116,6 +120,7 @@ struct font_files *read_font_files(int *count)
 			ret[*count-1].path8x14=strdup(fontpath);
 		if((ret[*count-1].path8x16=iniReadString(inifile,fontid,"Path8x16",NULL,fontpath))!=NULL)
 			ret[*count-1].path8x16=strdup(fontpath);
+		free(fontid);
 	}
 	fclose(inifile);
 	strListFree(&fonts);

src/syncterm/syncterm.c

@@ -986,6 +986,7 @@ void load_settings(struct syncterm_settings *set)
 	sortby=iniReadStringList(inifile, "SyncTERM", "SortOrder", ",", "5,1");
 	while((order=strListRemove(&sortby,0))!=NULL) {
 		sortorder[i++]=atoi(order);
+		free(order);
 	}
 	strListFree(&sortby);