Skip to content
Snippets Groups Projects
Commit 9416d37d authored by rswindell's avatar rswindell
Browse files

Bugfix: still initialize message header (e.g. version), even if msg->to==NULL.

Only call smb_unlocksmbhdr() if the base header is locked upon exit.
parent 2ba10a1e
No related branches found
No related tags found
No related merge requests found
...@@ -237,9 +237,6 @@ int SMBCALL smb_addmsg(smb_t* smb, smbmsg_t* msg, int storage, long dupechk_hash ...@@ -237,9 +237,6 @@ int SMBCALL smb_addmsg(smb_t* smb, smbmsg_t* msg, int storage, long dupechk_hash
fflush(smb->sdt_fp); fflush(smb->sdt_fp);
} }
if(msg->to==NULL) /* no recipient, don't add header (required for bulkmail) */
break;
msg->hdr.version=smb_ver(); msg->hdr.version=smb_ver();
if(msg->hdr.when_imported.time==0) { if(msg->hdr.when_imported.time==0) {
msg->hdr.when_imported.time=time(NULL); msg->hdr.when_imported.time=time(NULL);
...@@ -297,6 +294,9 @@ int SMBCALL smb_addmsg(smb_t* smb, smbmsg_t* msg, int storage, long dupechk_hash ...@@ -297,6 +294,9 @@ int SMBCALL smb_addmsg(smb_t* smb, smbmsg_t* msg, int storage, long dupechk_hash
if(smb_addhashes(smb,hashes,/* skip_marked? */FALSE)==SMB_SUCCESS) if(smb_addhashes(smb,hashes,/* skip_marked? */FALSE)==SMB_SUCCESS)
msg->flags|=MSG_FLAG_HASHED; msg->flags|=MSG_FLAG_HASHED;
if(msg->to==NULL) /* no recipient, don't add header (required for bulkmail) */
break;
retval=smb_addmsghdr(smb,msg,storage); /* calls smb_unlocksmbhdr() */ retval=smb_addmsghdr(smb,msg,storage); /* calls smb_unlocksmbhdr() */
} while(0); } while(0);
...@@ -305,7 +305,8 @@ int SMBCALL smb_addmsg(smb_t* smb, smbmsg_t* msg, int storage, long dupechk_hash ...@@ -305,7 +305,8 @@ int SMBCALL smb_addmsg(smb_t* smb, smbmsg_t* msg, int storage, long dupechk_hash
if(retval!=SMB_SUCCESS) if(retval!=SMB_SUCCESS)
smb_freemsg_dfields(smb,msg,1); smb_freemsg_dfields(smb,msg,1);
smb_unlocksmbhdr(smb); if(smb->locked)
smb_unlocksmbhdr(smb);
FREE_AND_NULL(lzhbuf); FREE_AND_NULL(lzhbuf);
FREE_LIST(hashes,n); FREE_LIST(hashes,n);
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment