Skip to content
Snippets Groups Projects
Commit a8cef60e authored by Deucе's avatar Deucе :ok_hand_tone4:
Browse files

Decorate intentional sleeps while holding lock

So they're auto-triaged in Synchronet.
parent 647fd0cc
No related branches found
No related tags found
No related merge requests found
Pipeline #7797 passed
......@@ -248,8 +248,10 @@ static void sdl_user_func(int func, ...)
return;
}
va_end(argptr);
while((rv = sdl.PeepEvents(&ev, 1, SDL_ADDEVENT, SDL_FIRSTEVENT, SDL_LASTEVENT))!=1)
while((rv = sdl.PeepEvents(&ev, 1, SDL_ADDEVENT, SDL_FIRSTEVENT, SDL_LASTEVENT))!=1) {
// coverity[sleep]
YIELD();
}
break;
}
pthread_mutex_unlock(&sdl_ufunc_mtx);
......@@ -274,8 +276,10 @@ static int sdl_user_func_ret(int func, ...)
case SDL_USEREVENT_SETVIDMODE:
ev.user.data1 = (void *)(intptr_t)va_arg(argptr, int);
ev.user.data2 = (void *)(intptr_t)va_arg(argptr, int);
while(sdl.PeepEvents(&ev, 1, SDL_ADDEVENT, SDL_FIRSTEVENT, SDL_LASTEVENT)!=1)
while(sdl.PeepEvents(&ev, 1, SDL_ADDEVENT, SDL_FIRSTEVENT, SDL_LASTEVENT)!=1) {
// coverity[sleep]
YIELD();
}
break;
case SDL_USEREVENT_GETWINPOS:
ev.user.data1 = va_arg(argptr, void *);
......@@ -284,6 +288,7 @@ static int sdl_user_func_ret(int func, ...)
case SDL_USEREVENT_INIT:
case SDL_USEREVENT_QUIT:
while(sdl.PeepEvents(&ev, 1, SDL_ADDEVENT, SDL_FIRSTEVENT, SDL_LASTEVENT)!=1)
// coverity[sleep]
YIELD();
break;
default:
......
......@@ -738,6 +738,7 @@ xptone_complete(void)
#ifdef XPDEV_THREAD_SAFE
pthread_mutex_lock(&handle_mutex);
#endif
// coverity[sleep]
xptone_complete_locked();
#ifdef XPDEV_THREAD_SAFE
pthread_mutex_unlock(&handle_mutex);
......@@ -818,6 +819,7 @@ xptone_close(void)
#ifdef XPDEV_THREAD_SAFE
pthread_mutex_lock(&handle_mutex);
#endif
// coverity[sleep]
ret = xptone_close_locked();
#ifdef XPDEV_THREAD_SAFE
pthread_mutex_unlock(&handle_mutex);
......@@ -1050,6 +1052,7 @@ void xp_play_sample_thread(void *data)
waited = true;
}
else {
// coverity[sleep]
xptone_close_locked();
}
}
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment