Skip to content
Snippets Groups Projects
Commit af28c04c authored by Rob Swindell's avatar Rob Swindell :speech_balloon:
Browse files

When server_binary option is set, request remote BINARY_TX option

As reported by Fzf (FQBBS):

It addresses the local configuration but unfortunately it still doesn't set
remote options.  The remote is usually going to be in binary mode but SVDM has
the remote option set to ASCII by default.  A CR from the remote then gets held
up until a second byte is sent.

Also suggested by Fzf, when server_binary mode is not configured, then advertise
and request binary mode is/be disabled, explicitly.
parent 252b1dc3
No related branches found
No related tags found
1 merge request!455Update branch with changes from master
Pipeline #6333 passed
......@@ -731,8 +731,11 @@ void init_telnet_options()
request_telnet_opt(TELNET_WILL,TELNET_ECHO);
}
if(cfg.server_binary) {
/* Will send in binary mode (no CR->CRLF expansion on receiver side) */
request_telnet_opt(TELNET_WILL,TELNET_BINARY_TX);
request_telnet_opt(TELNET_DO, TELNET_BINARY_TX);
request_telnet_opt(TELNET_WILL, TELNET_BINARY_TX);
} else {
request_telnet_opt(TELNET_DONT, TELNET_BINARY_TX);
request_telnet_opt(TELNET_WONT, TELNET_BINARY_TX);
}
/* Will suppress Go Ahead */
request_telnet_opt(TELNET_WILL,TELNET_SUP_GA);
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment