Detect smb_[f]allocdat() failure in editmsg()

CID 319091

Detect smb_[f]allocdat() failure in editmsg()
CID 319091
b47b97c2 · Rob Swindell · 41ce191d · b47b97c2
Commit b47b97c2 authored Mar 02, 2022 by Rob Swindell 💬
Hide whitespace changes
Inline Side-by-side

Showing with 6 additions and 0 deletions

src/sbbs3/writemsg.cpp src/sbbs3/writemsg.cpp +6 -0

No files found.
--- a/src/sbbs3/writemsg.cpp
+++ b/src/sbbs3/writemsg.cpp
@@ -1681,6 +1681,12 @@ bool sbbs_t::editmsg(smb_t* smb, smbmsg_t *msg)
 		smb_close_da(smb);
 	}

+	if(offset < 0) {
+		smb_unlocksmbhdr(smb);
+		errormsg(WHERE,ERR_ALLOC,msgtmp,length);
+		return false;
+	}
+
 	msg->hdr.offset=(uint32_t)offset;
 	if((file=open(msgtmp,O_RDONLY|O_BINARY))==-1
 		|| (instream=fdopen(file,"rb"))==NULL) {