Merge branch 'ddmsgreader_lightbar_area_change_highlight_fix' into 'master'

Bug fix for changing message area with lightbar

See merge request !108

xtrn/DDMsgReader/DDMsgReader.js

@@ -77,6 +77,16 @@
  * 2021-01-31 Michael Long      Version 1.40
  *                              Fixed left/right colors not being customizable on message
  *                              list lightbar
+ * 2021-02-12 Eric Oulashin     Version 1.41
+ *                              Bug fix: When changing to another area with the lightbar
+ *                              interface, if the user's current sub-board is a high-numbered
+ *                              sub-board and they select a message group with fewer
+ *                              sub-boards, the highlighted sub-board in that group would
+ *                              be set to that high number and would be incorrect.
+ *                              That has been fixed.  Copied a fix from my stand-alone
+ *                              message area chooser.  In that scenario, the current
+ *                              highlighted sub-board in the other group will be
+ *                              the first one.
  */
@@ -188,8 +198,8 @@ if (system.version_num < 31500)
 }
 // Reader version information
-var READER_VERSION = "1.40";
-var READER_DATE = "2021-01-31";
+var READER_VERSION = "1.41";
+var READER_DATE = "2021-02-12";
 // Keyboard key codes for displaying on the screen
 var UP_ARROW = ascii(24);
@@ -3952,9 +3962,17 @@ function DigDistMsgReader_CreateLightbarSubBoardMenu(pGrpIdx)
 	};
 	// Set the currently selected item to the current group
-	subBoardMenu.selectedItemIdx = msg_area.sub[this.subBoardCode].index;
-	if (subBoardMenu.selectedItemIdx >= subBoardMenu.topItemIdx+subBoardMenu.GetNumItemsPerPage())
-		subBoardMenu.topItemIdx = subBoardMenu.selectedItemIdx - subBoardMenu.GetNumItemsPerPage() + 1;
+	if (msg_area.sub[this.subBoardCode].grp_index == pGrpIdx)
+	{
+		subBoardMenu.selectedItemIdx = msg_area.sub[this.subBoardCode].index;
+		if (subBoardMenu.selectedItemIdx >= subBoardMenu.topItemIdx+subBoardMenu.GetNumItemsPerPage())
+			subBoardMenu.topItemIdx = subBoardMenu.selectedItemIdx - subBoardMenu.GetNumItemsPerPage() + 1;
+	}
+	else
+	{
+		subBoardMenu.selectedItemIdx = 0;
+		subBoardMenu.topItemIdx = 0;
+	}
 	return subBoardMenu;
 }
@@ -5481,33 +5499,19 @@ function DigDistMsgReader_ScrollReaderDetermineClickCoordAction(pScrollRetObj, p
 			else if (pEnhReadHelpLineClickCoords[coordIdx].actionStr.indexOf("DEL") == 0)
 				retObj.actionStr = this.enhReaderKeys.deleteMessage;
 			else if (pEnhReadHelpLineClickCoords[coordIdx].actionStr.indexOf("E)") == 0)
-			{
 				retObj.actionStr = this.enhReaderKeys.editMsg;
-			}
 			else if (pEnhReadHelpLineClickCoords[coordIdx].actionStr.indexOf("F") == 0)
-			{
 				retObj.actionStr = this.enhReaderKeys.firstMsg;
-			}
 			else if (pEnhReadHelpLineClickCoords[coordIdx].actionStr.indexOf("L") == 0)
-			{
 				retObj.actionStr = this.enhReaderKeys.lastMsg;
-			}
 			else if (pEnhReadHelpLineClickCoords[coordIdx].actionStr.indexOf("R") == 0)
-			{
 				retObj.actionStr = this.enhReaderKeys.reply;
-			}
 			else if (pEnhReadHelpLineClickCoords[coordIdx].actionStr.indexOf("C") == 0)
-			{
 				retObj.actionStr = this.enhReaderKeys.chgMsgArea;
-			}
 			else if (pEnhReadHelpLineClickCoords[coordIdx].actionStr.indexOf("Q") == 0)
-			{
 				retObj.actionStr = this.enhReaderKeys.quit;
-			}
 			else if (pEnhReadHelpLineClickCoords[coordIdx].actionStr.indexOf("?") == 0)
-			{
 				retObj.actionStr = this.enhReaderKeys.showHelp;
-			}
 			break;
 		}
 	}

xtrn/DDMsgReader/readme.txt

                       Digital Distortion Message Reader
-                                 Version 1.40
-                           Release date: 2021-12-31
+                                 Version 1.41
+                           Release date: 2021-02-12
 
                                      by
 

xtrn/DDMsgReader/revision_history.txt

@@ -5,6 +5,15 @@ Revision History (change log)
 =============================
 Version  Date         Description
 -------  ----         -----------
+1.41     2021-02-12   Bug fix: When changing to another area with the lightbar
+                      interface, if the user's current sub-board is a
+                      high-numbered sub-board and they select a message group
+                      with fewer sub-boards, the highlighted sub-board in that
+                      group would be set to that high number and would be
+                      incorrect.  That has been fixed.  Copied a fix from my
+                      stand-alone message area chooser.  In that scenario, the
+                      current highlighted sub-board in the other group will be
+                      the first one.
 1.40     2021-01-31   (Michael Long) Fixed left/right colors not being
                       customizable on message list lightbar
 1.39     2020-12-01   When forwarding a message, added the ability to optinally