Skip to content
Snippets Groups Projects
Commit c73f9bdb authored by Rob Swindell's avatar Rob Swindell
Browse files

Fix up the unzip command-line introduced in mlong's enhancements

1. You can't include % specifiers in the string passed to system.exec()
   - this is just a wrapper for system(), it doesn't recongize Synchronet
     command-line specifiers.
   - so I just prepend the exec_dir for Win32, leave off for *nix.
   - it appears this wasn't tested since that command-line would not work.

2. Added 'j' option to unzip. We don't want the extraction of infopacks with
   sub-directories to be creating sub-directories under our ctrl dir.
   We should consider extracting to a temp dir instead of the ctrl dir if
   we don't have absolute control over what's being extracted from downloaded
   zip files. This could be dangerous if we're not extremely careful.
parent 5b4e44de
No related branches found
No related tags found
1 merge request!463MRC mods by Codefenix (2024-10-20)
Pipeline #468 passed
Loading
  • Developer

    that is interesting, it DID work on linux for me. Maybe it filtered %@ out some how?

  • Owner

    Yeah, weird. Well, it wouldn't have worked on Windows. :-)

0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment