Skip to content
Snippets Groups Projects
Commit d90ea2b8 authored by rswindell's avatar rswindell
Browse files

smb_netaddr_type() (exposed via JS as netaddr_type()) change:

prior to rev 1.29 of this file (committed almost exactly one year ago), when
called with any string that did not include an '@', would return NET_NONE (0).
After rev 1.29, most strings that did not include an '@' would cause the
function to return NET_QWK (4) - this was not intentional. The intention was
that FidoNet addresses without an '@' would cause this function to return
NET_FIDO (2) and I don't exactly remember why that change was made, but
unfortunately, it wasn't made very well, so other invalid addresses would be
detected as NET_QWK or NET_INTERNET or even NET_UNKNOWN.
So before and after this commit:
"" was NET_UNKNOWN, now NET_NONE
"1" was NET_FIDO, now NET_FIDO
"1x" was NET_INTERNET, now NET_NONE
"1:103" was NET_FIDO, now NET_FIDO (this could use some work)
"x" was NET_QWK, now NET_NONE
parent 8bd7cbdd
No related branches found
No related tags found
No related merge requests found
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment