Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
Synchronet
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Package Registry
Container Registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Main
Synchronet
Commits
e371604e
Commit
e371604e
authored
3 years ago
by
Rob Swindell
Browse files
Options
Downloads
Patches
Plain Diff
Check return value of fseek() and fstat()
CID 330960, 330967, 330988
parent
90b7b12c
No related branches found
No related tags found
No related merge requests found
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
src/sbbs3/filedat.c
+15
-4
15 additions, 4 deletions
src/sbbs3/filedat.c
with
15 additions
and
4 deletions
src/sbbs3/filedat.c
+
15
−
4
View file @
e371604e
...
...
@@ -152,11 +152,13 @@ str_list_t loadfilenames(smb_t* smb, const char* filespec, time_t t, enum file_s
return
NULL
;
}
if
(
fseek
(
smb
->
sid_fp
,
start
*
sizeof
(
fileidxrec_t
),
SEEK_SET
)
!=
0
)
return
NULL
;
char
**
file_list
=
calloc
(
smb
->
status
.
total_files
+
1
,
sizeof
(
char
*
));
if
(
file_list
==
NULL
)
return
NULL
;
fseek
(
smb
->
sid_fp
,
start
*
sizeof
(
fileidxrec_t
),
SEEK_SET
);
size_t
offset
=
start
;
while
(
!
feof
(
smb
->
sid_fp
)
&&
offset
<
smb
->
status
.
total_files
)
{
fileidxrec_t
fidx
;
...
...
@@ -197,11 +199,13 @@ file_t* loadfiles(smb_t* smb, const char* filespec, time_t t, enum file_detail d
return
NULL
;
}
if
(
fseek
(
smb
->
sid_fp
,
start
*
sizeof
(
fileidxrec_t
),
SEEK_SET
)
!=
0
)
return
NULL
;
file_t
*
file_list
=
calloc
(
smb
->
status
.
total_files
,
sizeof
(
file_t
));
if
(
file_list
==
NULL
)
return
NULL
;
fseek
(
smb
->
sid_fp
,
start
*
sizeof
(
fileidxrec_t
),
SEEK_SET
);
size_t
offset
=
start
;
size_t
cnt
=
0
;
while
(
!
feof
(
smb
->
sid_fp
)
&&
offset
<
smb
->
status
.
total_files
)
{
...
...
@@ -407,7 +411,10 @@ bool batch_file_add(scfg_t* cfg, uint usernumber, enum XFER_TYPE type, file_t* f
FILE
*
fp
=
batch_list_open
(
cfg
,
usernumber
,
type
,
/* create: */
true
);
if
(
fp
==
NULL
)
return
false
;
fseek
(
fp
,
0
,
SEEK_END
);
if
(
fseek
(
fp
,
0
,
SEEK_END
)
!=
0
)
{
fclose
(
fp
);
return
false
;
}
fprintf
(
fp
,
"
\n
[%s]
\n
"
,
f
->
name
);
if
(
f
->
dir
>=
0
&&
f
->
dir
<
cfg
->
total_dirs
)
fprintf
(
fp
,
"dir=%s
\n
"
,
cfg
->
dir
[
f
->
dir
]
->
code
);
...
...
@@ -760,7 +767,11 @@ long create_archive(const char* archive, const char* format
safe_snprintf
(
error
,
maxerrlen
,
"%d opening %s"
,
errno
,
filename
);
break
;
}
fstat
(
fileno
(
fp
),
&
st
);
if
(
fstat
(
fileno
(
fp
),
&
st
)
!=
0
)
{
safe_snprintf
(
error
,
maxerrlen
,
"%d fstat %s"
,
errno
,
filename
);
fclose
(
fp
);
break
;
}
if
((
entry
=
archive_entry_new
())
==
NULL
)
{
safe_snprintf
(
error
,
maxerrlen
,
"archive_entry_new returned NULL"
);
fclose
(
fp
);
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment