Skip to content
Snippets Groups Projects
Commit ec3f6c0d authored by Rob Swindell's avatar Rob Swindell :speech_balloon:
Browse files

Fix CID 486181: Resource leak (RESOURCE_LEAK)

A couple of error paths in expand_atcodes() method could leak heap memory.
parent b8e2c852
No related branches found
No related tags found
1 merge request!455Update branch with changes from master
......@@ -1726,11 +1726,15 @@ js_expand_atcodes(JSContext* cx, uintN argc, jsval* arglist)
if(JSVAL_IS_OBJECT(argv[1]) && !JSVAL_IS_NULL(argv[1])) {
JSObject* hdrobj;
if((hdrobj = JSVAL_TO_OBJECT(argv[1])) == NULL)
if((hdrobj = JSVAL_TO_OBJECT(argv[1])) == NULL) {
free(instr);
return JS_FALSE;
if(!js_GetMsgHeaderObjectPrivates(cx, hdrobj, /* smb_t: */NULL, &msg, /* post: */NULL))
}
if(!js_GetMsgHeaderObjectPrivates(cx, hdrobj, /* smb_t: */NULL, &msg, /* post: */NULL)) {
free(instr);
return JS_FALSE;
}
}
rc = JS_SUSPENDREQUEST(cx);
sbbs->expand_atcodes(instr, result, sizeof result, msg);
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment