Merge branch 'dd_msg_reader_indexed_mark_all_read_and_fixes' into 'master'

DDMsgReader: Indexed mode: Added 'mark all read' for a sub-board with the R key. Fixed message list colors for messages to the user in the message lists. Fix for continuous newscan. Fix for DDLIghtbarMenu numbered mode item text in traditional UI.

See merge request !361

docs/slyedit_readme.txt

                          SlyEdit message editor
-                              Version 1.86
+                              Version 1.87
                         Release date: 2023-08-15
 
                                   by
@@ -239,8 +239,22 @@ Ctrl-O       : Import a file
 =====================
 The configuration file, SlyEdit.cfg, is split up into 3 sections -
 Behavior, Ice colors, and DCT colors.  These sections are designated
-by [BEHAVIOR], [ICE_COLORS], and [DCT_COLORS], respectively.  These
-settings are described below:
+by [BEHAVIOR], [ICE_COLORS], and [DCT_COLORS], respectively.
+
+To help with configuration, there is a menu-driven configuration script in
+sbbs/exec called slyedcfg.js. To run it, open a command prompt in the sbbs/exec
+directory and run it with this command:
+jsexec slyedcfg
+
+Alternately, you can specify the .js filename extension if you want to:
+jsexec slyedcfg.js
+
+The configuration script will copy your SlyEdit configuration file to your
+sbbs/mods directory to help prevent it from being accidentally overridden when
+doing an update from the Synchronet source repository. SlyEdit will pick up its
+configuration from sbbs/mods if the configuration file is there.
+
+The configuration settings are described below:
 
 Behavior settings
 -----------------

exec/load/dd_lightbar_menu.js

@@ -1057,9 +1057,9 @@ function DDLightbarMenu_Draw(pSelectedItemIndexes, pDrawBorders, pDrawScrollbar,
 		{
 			var showMultiSelectMark = (this.multiSelect && (typeof(pSelectedItemIndexes) == "object") && pSelectedItemIndexes.hasOwnProperty(idx));
 			var itemText = this.GetItemText(i, itemLen, false, showMultiSelectMark);
-			// TODO: It seems the text must be shortened by 3 less than the console width or else
-			// it behaves like there's an extra CRLF
-			console.print(substrWithAttrCodes(itemText, 0, console.screen_columns-3) + "\x01n");
+			// TODO: Once, it seemed the text must be shortened by 3 less than the console width or else
+			// it behaves like there's an extra CRLF, but 2 should be correct.
+			console.print(substrWithAttrCodes(itemText, 0, console.screen_columns-2) + "\x01n");
 			console.crlf();
 		}
 		this.numberedMode = numberedModeBackup;
@@ -2125,6 +2125,7 @@ function DDLightbarMenu_GetVal(pDraw, pSelectedItemIndexes)
 			console.print("\x01n\x01c\x01hY\x01n\x01cour \x01hC\x01n\x01choice\x01h\x01g: \x01c");
 			console.attributes = "N";
 			var userEnteredItemNum = console.getnum(numItems);
+			this.lastUserInput = userEnteredItemNum.toString();
 			if (!console.aborted && userEnteredItemNum > 0)
 			{
 				if (this.ItemIsSelectable(userEnteredItemNum-1))

xtrn/DDMsgReader/readme.txt

                       Digital Distortion Message Reader
-                                 Version 1.85
-                           Release date: 2023-11-01
+                                 Version 1.86
+                           Release date: 2023-11-09
 
                                      by
 
@@ -178,10 +178,18 @@ Digital Distortion Message Reader is comprised of the following files:
 
 2. DDMsgReader.cfg        The reader configuration file
 
-3. DefaultTheme.cfg       The default theme file containing colors & some
+3. ddmr_cfg.js            A menu-driven configuration script to help with
+                          changing configuration options. You can run it at a
+                          command prompt in the DDMsgReader directory with the
+                          following command:
+                          jsexec ddmr_cfg
+                          Alternately (with the filename extension):
+                          jsexec ddmr_cfg.js
+
+4. DefaultTheme.cfg       The default theme file containing colors & some
                           configurable text strings used in the reader
 
-4. ddmr_lm.js             Loadable module script for setup in SCFG (only needed
+5. ddmr_lm.js             Loadable module script for setup in SCFG (only needed
                           for Synchronet 3.19 and earlier, or Synchronet built
                           before 2023-02-20)
 
@@ -572,9 +580,21 @@ user avatar.
 6. Configuration file & color/text theme configuration file
 ===========================================================
 Digital Distortion Message Reader allows changing some settings, colors, and
-some of the text via configuration files.  The configuration files are plain
-text and can be edited with any text editor.  These are the configuration files
-used by Digital Distortion Message Reader:
+some of the text via configuration files.
+
+Also, ddmr_cfg.js is a menu-driven configuration script to help with changing
+configuration options. You can run it at a command prompt in the DDMsgReader
+directory with the following command:
+jsexec ddmr_cfg
+Alternately (with the filename extension):
+jsexec ddmr_cfg.js
+
+If you have DDMsgReader in the standard location (xtrn/DDMsgReader), ddmr_cfg
+will copy the configuration file to your sbbs/mods directory to help prevent it
+from being accidentally overridden by updating the standard Synchronet files.
+
+The configuration files are plain text and can be edited with any text editor.
+These are the configuration files used by Digital Distortion Message Reader:
 - DDMsgReader.cfg: The main configuration file
 - DefaultTheme.cfg: Defines colors & some text strings used in the reader.
   The name of this file can be specified in DDMsgReader.cfg, so that alternate

xtrn/DDMsgReader/revision_history.txt

@@ -5,6 +5,15 @@ Revision History (change log)
 =============================
 Version  Date         Description
 -------  ----         -----------
+1.86     2023-11-09   New feature: For indexed mode, when choosing a sub-board,
+                      the R key can be used to mark all messages as read in the
+                      sub-board.
+                      Fix: For continuous newscan or browse newscan (SCAN_BACK),
+                      call the stock Synchronet behavior (DDMsgReader did this
+                      previously, as DDMsgReader doesn't implement those yet).
+                      Fix: In the message list, to-user alternate colors weren't
+                      being used unless the message was read. The correct colors
+                      are used again.
 1.85     2023-11-01   Mark personal email as read if the user is just reading
                       personal email
 1.84     2023-10-26   Fix in reader mode for refreshing the message area after