Skip to content
Snippets Groups Projects
Commit f06029a3 authored by Deucе's avatar Deucе :ok_hand_tone4:
Browse files

Add TODO comment for cvstat.

When originally created, it was intended to be accessed only by a
single thread, and therefore not need mutex protection, allowing
less code to run with vstatlock held.  Unfortunately, this is not
how it turned out, so cvstat should either be removed, or it should
actually be cleaned up to work as intended.
parent 6369925c
No related branches found
No related tags found
1 merge request!463MRC mods by Codefenix (2024-10-20)
Pipeline #4103 passed
...@@ -65,6 +65,17 @@ pthread_mutex_t sdl_keylock; ...@@ -65,6 +65,17 @@ pthread_mutex_t sdl_keylock;
sem_t sdl_key_pending; sem_t sdl_key_pending;
static unsigned int sdl_pending_mousekeys=0; static unsigned int sdl_pending_mousekeys=0;
/*
* TODO:
* The intent of this was a copy of current vstat that
* does not require vstatlock to be held.
*
* Unfortunately, this is accessed from multiple threads
* currently (at least main and video events), so it
* requires *a* lock, and vstatlock is used for that purpose.
* This should either have its own lock, or be used *only*
* from a single thread.
*/
static struct video_stats cvstat; static struct video_stats cvstat;
struct sdl_keyvals { struct sdl_keyvals {
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment