Skip to content
Snippets Groups Projects
Commit f6b4f4d0 authored by rswindell's avatar rswindell
Browse files

Eliminated possible bounds problem with vsprintf in fs_printf().

parent 315027eb
No related branches found
No related tags found
No related merge requests found
......@@ -110,7 +110,7 @@ js_print(JSContext *cx, JSObject *obj, uintN argc, jsval *argv, jsval *rval)
static JSBool
js_printf(JSContext *cx, JSObject *obj, uintN argc, jsval *argv, jsval *rval)
{
char tmp[1024];
char* p;
uintN i;
JSString * fmt;
JSString * str;
......@@ -136,8 +136,11 @@ js_printf(JSContext *cx, JSObject *obj, uintN argc, jsval *argv, jsval *rval)
arglist[i-1]=NULL;
}
vsprintf(tmp,JS_GetStringBytes(fmt),(char*)arglist);
sbbs->bputs(tmp);
if((p=JS_vsmprintf(JS_GetStringBytes(fmt),(char*)arglist))==NULL)
return JS_FALSE;
sbbs->bputs(p);
JS_smprintf_free(p);
return JS_TRUE;
}
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment