Function 0Ch (peek) never worked correctly (character was not returned in AX); I guess nothing uses this function (?).

Function 01h (transmit char w/wait) now will set the timeout flag (0x8000) in the AX if the VDD_WRITE function fails (returns value other than 1).

Optimize Function 18h (read block) - no need for the extra VDD_STATUS call.

Use newly defined FOSSIL macros instead of magic numbers of port status bits.

Log the git branch/hash values to the Windows debug log (via sbbsexec.dll).

The sem_wait() call from vdd_read() that was fixed in the previous commit to this file was a bad idea to begin with:
There is (often) not a 1:1 ratio of bytes in the receive ring buffer and the semaphore count, so we'd often halt here waiting for the semaphore to be signaled even though there were still characters in the receive buffer. This caused (new) stalls/hangs in keyboard input in DOS door games. We didn't see this previously because the sem_wait() call just didn't work (wrong semaphore pointer value).

Now, call sem_trywait_block() in vdd_read(), but only if the RingBufRead() returned 0 (no bytes read) and even then, only block/wait for a maximum of 30 seconds (same as X00 FOSSIL driver). This blocking behavior is specified for FOSSIL function 02h (Get received character with wait) and would not have worked previous to the previous "fix", so now we have that corrected behavior too. The FTSC spec says the wait is indefinite, but I think a 30 second timeout (ala X00) is more reasonable.

Log the git brach/hash instead of the old CVS revision.

GetMailSlotInfo() apparently always fails on Windows 7 with error 87 (even using Microsoft's own sample code), so lower the log message severity of that failure from ERR to DEBUG. Apparently this is pretty harmless anyway as nothing really needs the write-mailslot status. <shrug>

Is this the point when the lost chars problem happens?

As reported via irc by Nelgin, the setcap target was not being passed
to 'make -C src/sbbs3' by default (on Linux) due to a misplaced paren.

Yes, you can run 16-bit DOS doors on 64-bit (x64) Windows now.

Install NTVDMx64 (http://www.columbia.edu/~em36/ntvdmx64.html, it's not as onerous as it sounds) and re-enable DOS program support in SBBS (i.e. make sure "NO_DOS" is not in your sbbs.ini [bbs] Options value) and voila: DOS doors work.

This change adds an empty init routine to sbbsexec.dll since older versions of NTVDM (which NTVDMx64 is based on) required one. Also, the sbbsexec.dll should be located in your Synchronet "exec" directory when using NTVDMx64 (in addition to or instead of your Windows/System32 directory).

Using options (e.g. RINGBUF_MUTEX) from old sbbsexec.dsp

Missing part of commit 4da964dd

Introduced in Revision 1.16 (CVS)
Wed May 10 08:52:11 2006 UTC (15 years, 6 months ago) by rswindell

This was supposed to wait (block) until there was a new received
byte (the ringbuf semaphore was signaled), but we were passing the sem_t
value rather than the pointer to the sem_t. Since sem_t (on Windows)
is a HANDLE (which is a void*), there was no compiler warning or
error. Type-safety in C sucks.
So, this just never worked (I'm assuming the call would just fail).

I discovered this bug while working on NTVDMx64 support and in that
case, this call would block/wait forever. Simple one character fix.

But also, this needs some revision since I'm supposed to send
the header all at once and probably shouldn't be doing a bunch
of individual sendBin calls.

Added incomplete send of haproxy protocol header. Need to sort
out lookup of target (BBS) IP address.

other unnecessary work - if the BBS is using HAProxy but we can't
do the thing with the stuff because we don't have the things.

then throw an error if X-Forwarded-For header was not received,
or otherwise do the HAProxy thing upon connecting.

like to mangle these unless you tell them not to.

Capture the value of the X-Forwarded-For header, if present, and
stash it in FWebSocketHeader['X-Forwarded-For'].

As a work around for TradeWars 2 (v11.14 and v11.20) FOSSIL support:
This door game would never call the FOSSIL "get received character"
function (02h) . But I did notice that it was calling the "Keyboard
read" functions. I never implemented the "Keyboard read" functions
(figured the door game could read the keyboard itself if it wanted to),
but appparently TW2 won't ever read the COM port (using function 02h)
unless the Keyboard read function returns AX=0xFFFF (no keyboard data
available). So now, I just do that and TW2 works (with FOSSIL I/O).

Incremented the revision to 26.
Logging the Git branch/hash and other helpful FOSSIL-debug stuff now.

Needed the actually mapping of XTRN_UART -> EX_UART mode flag here.

When configuring an external program, a Win32 sysop can now choose to *only* enable the virtual UART (and not the FOSSIL driver) feature of the Synchronet virtual UART/FOSSIL driver (dosxtrn.exe/sbbsexec.dll). Some programs (e.g. TradeWars 2) will always use the FOSSIL driver if one is detected and in order to force the use of COM/UART driver for I/O (if that is desired), then one must disable the FOSSIL driver. It's a rare use case, but I can see the potential need.

Renamed the "Intercept I/O" option in SCFG to "I/O Method" and make it clear that "Socket" (for native programs) and "FOSSIL or UART" (for 16-bit DOS programs) is the default method (what was previously identified as "No" I/O Interception).

If a sysop want to disable the virtual UART support (on Win32, e.g. so *only* FOSSIL is available to one or all DOS programs), they do that via their sbbsexec.ini file.

This change needed to build dosxtrn.exe (again).

warning: format ‘%lx’ expects argument of type ‘long unsigned int’

The internal line editor's quoting feature add some hard-coded strings ("Done" and "All") and the (L)ist key was hard-coded. Use the text.dat string (new and pre-existing) for these now.

Also, use the new sbbs_t *_key() methods for referencing the configured key bindings (via text.dat) for these common key-stroke commands.
Convert the text.dat strings for keys (e.g. YNQP) to uppercase always as well.

For localization purposes, no more hard-coded text strings or characters in the new-file and file scan configuration menus.

This change fixes issue 232.

A Hungarian sysop also requested this change via Facebook not long ago.

sbbsctrl.exe is built with Borland C++ still which only has a 32-bit time_t, so to keep the scfg_t definition compatible between MSVC and Borland builds, use time32_t (32-bit time_t) values only.

This fixes the reported sbbsctrl.exe error:
Error loading configuration
cfg->size (23944) != sizeof(scfg_t) (23952)

Introduced in commit e535aaac.
Reported via DOVE-Net by  Daryl Stout (TBOLT), confirmed by Nightfox (DIGDIST).

Since mail server log messages have their white-space condensed, it was not obvious why some sender's name would match a twitlist.cfg line that filters names beginning with a space: "\ *" because the initial space of the sender's name was condensed/combined with space before it in the log message.

As found and reported by Talisam author, apam (HAPPYLND).

sscanf() won't initialize the buffer of the argument passed if the format string is not matched, so when there was no hexadecimal/SMB timezone value, the timezone specified in the ISO date/time string (if any) would be overwritten with 0, converted from the uninitialized 'zone' variable (unlikely to be valid hex-ASCII chars). Thanks apam!

where "address" is a QWKnet ID or path or a FidoNet originating address. Wildcards can be used (e.g. "*@VERT").

For Trikester.

%+ will now expand to the current user's real name, automatically enclosed in quotes if it contains any spaces.

The "serialno" field is a bad/naive one (a time_t value), but this is really just an experiment for Ragnarok to see if this fixes issue #306 (with hotdoged receiving AreaFix responses/notices).

Found during review of previous commit.
Introduced as part of the new file base branch merge (commit fcf58640).

Environment variables are shared among all threads of a process (e.g. all nodes of a instance of sbbs), so this scheme of passing the uploaded filename and description to an external file tester (upload processor) via environment variables has always been fraught with the possibility of failure or flakiness in Synchronet v3. Since I very much doubt that any upload processor is actually using this scheme, just remove it. Upload processors can and should)use the sbbsfile.nam and sbbsfile.des text files created in the node directory instead.

When a linked-node (in echocfg->Linked Nodes) contains one of the local system's FTN addresses, display/log an error and exit immediately, e.g.:
Configuration ERROR: Linked node #20 is your own address: 1:103/705

I'd perform this check in EchoCfg, but:
1. echocfg doesn't read the BBS's configuration files (where the local FTN addresses are configured), and
2. some sysops just directly edit their sbbsecho.ini file