Skip to content
Snippets Groups Projects
  1. Jun 10, 2021
    • Rob Swindell's avatar
      Standardize on "metadata" as the description of a file's "tail" dfield · 1993a13c
      Rob Swindell authored
      It's anticipated that this will be used for JS-populated file metadata in JSON format in the future (and not just "archive contents" in .ini format).
      
      Also, fix the double-free issue that was occurring when moving files with extended file descriptions (sbbs_t::movefile()). This was actually the primary problem I was fixing here, but noticed the metadata issue: metadata would not have been moved along with the other file info between bases.
      1993a13c
    • Rob Swindell's avatar
      mv() simplified for the non-copy case · 2bab4339
      Rob Swindell authored
      Constified function arguments. Source path is still case-insensitive, but destination is case-sensitive (hopefully that's not an issue).
      
      When a "move" (!copy) is requested, a rename() is always attempted first and if successful, job done. Otherwise, we continue on with the file-copy (and then remove).
      
      This should resolve CID 332219 (DEADCODE).
      2bab4339
    • Rob Swindell's avatar
      Call smb_freefilemem() instead of smb_msgmem() for files · dc028bf2
      Rob Swindell authored
      Not that it really matters, but perhaps it'll matter in the future. And the code reads better.
      dc028bf2
  2. Jun 09, 2021
  3. Jun 08, 2021
  4. Jun 07, 2021
    • Rob Swindell's avatar
      Modernize finduser() a bit · 32d45ed7
      Rob Swindell authored
      Skip any prepended white-space in the passed name to find.
      Use better variable names (and length) for the character strings.
      Use matchusername() instead of strcmp(); matchusername() follows the liberal user-id/alias/name matching algorithm.
      Use strcasestr() instead of strstr(), so no copy/modification (upper-casing) of passed name is now required.
      When 'Q'uitting the search, set the SS_ABORT flag.
      32d45ed7
    • Rob Swindell's avatar
      1e31300f
  5. Jun 06, 2021
  6. Jun 05, 2021
    • Rob Swindell's avatar
      Add new commands to flag/unflag all messages for deletion · a8a42afc
      Rob Swindell authored
      The command to delete and remove all messages is changed from 'd' to 'D'.
      This operation is not reversable.
      
      New commands are 'd' (flag all msgs for deletion) and 'u' (undelete all msgs).
      a8a42afc
    • Rob Swindell's avatar
      Don't allow colons in web-requested path names on Windows · 9e59532a
      Rob Swindell authored
      This fixes issue #269 (NTFS Alternate Data Stream vulnerability) and other
      potential pathname issues on Windows involving colons.
      
      There are other illegal filename characters on Windows (e.g. <>|"?*), but
      filenames with these characters aren't expected to pass the later stat() test,
      so should fail with a 404 error.
      9e59532a
Loading