Skip to content
Snippets Groups Projects
  1. Dec 23, 2023
    • Rob Swindell's avatar
      Add/use realloc_or_free() instead of realloc() in some places · 19e7f21e
      Rob Swindell authored
      Where ever we assign the realloc() result to the same pointer we pass, use this new function instead to eliminate the cppcheck error reported by Nelgin:
      Common realloc mistake: 'p' nulled but not freed upon failure  [memleakOnRealloc]
      
      This isn't going to actually solve any memory leaks, it's just good practice for critical error (e.g. no memory error) handling.
      19e7f21e
  2. Jun 05, 2023
  3. Jun 04, 2023
    • Rob Swindell's avatar
      Fix warnings raised by gcc -D_FORTIFY_SOURCE=3 -O1 · 8667e329
      Rob Swindell authored
      A bunch of possible (but often, not really) use of undefined values.
      Some ignored return values (e.g. of chsize/ftruncate, read, write, fgets).
      
      Other than some added diagnostics upon some of these unexpected syscall
      failures, there should be no change in behavior from this commit.
      8667e329
  4. May 24, 2023
  5. Apr 09, 2022
  6. Mar 10, 2022
  7. Apr 26, 2021
  8. Apr 04, 2021
    • Rob Swindell's avatar
      A poll() failure with EINTR does not mean a socket is closed. · 925e3b0a
      Rob Swindell authored
      This won't impact Synchronet as it has a separate signal handling
      thread, but we still need to behave properly for processes that
      don't.  I'm also saying that ENOMEM does not indicate a disconnection,
      though it may be better to pretend it was disconnected...
      925e3b0a
  9. Feb 15, 2021
  10. Feb 14, 2021
  11. Jan 18, 2021
    • Rob Swindell's avatar
      Safe string handling with config-load error messages · 4a13b65d
      Rob Swindell authored
      We were just trusting that the error strings would be shorter than 256 (usually), but since we're including paths and strerror() results, we really have no control over the length of the error strings. So enforce some healthy boundaries. This could explain the crashes that Divarin of Mutiny is seeing with SCFG on WinXP or maybe it was the truncsp(strerror()) stuff that was just removed as well. We'll see...
      4a13b65d
  12. Nov 23, 2020
    • Rob Swindell's avatar
      The great C function dependency refactor of 2020 · cee2d280
      Rob Swindell authored
      The goal of this commit is that: only modules that either are part-of sbbs.dll/libsbbs.so or need to link with/use that library, will #include "sbbs.h" and thus be dependent on its subsequent includes (e.g. cryptlib.h, jsapi.h). This should mean extdeps.mk can be trimmed way down.
      
      I also removed CVS keyword/comments and trimmed up the boilerplate copyright notice in modified and added source/header files in this commit.
      
      There is no functional change in behavior in this comment.
      cee2d280
  13. Sep 19, 2020
  14. Aug 17, 2020
  15. Aug 16, 2020
    • Rob Swindell's avatar
      Fix issue with jsexec being used for CGI scripts · 54431b31
      Rob Swindell authored
      If jsexec is used for a CGI script and the SBBSCTRL env var was not
      set, a warning would be printed (to stderr), even if the -c option
      was used to specify the path to the ctrl dir.
      
      get_ctrl_dir() now accepts a boolean argument to specify whether to
      print a warning when the default value ("/sbbs/ctrl") is used.
      Pass FALSE for jsexec, TRUE for other callers (currently).
      54431b31
    • Rob Swindell's avatar
      Commit with CVS Keywords expanded. · dfa1a0a4
      Rob Swindell authored
      dfa1a0a4
  16. Jan 03, 2020
    • rswindell's avatar
      Add/use a new get_ctrl_dir() function to query the SBBSCTRL env var and if · b236be71
      rswindell authored
      not set (or blank), use the default ("/sbbs/ctrl") and print a warning to
      stderr. This resolves a FAQ for sysops that struggle with setting the SBBSCTRL
      env var, but do have sbbs install in /sbbs or a symlink from /sbbs to where
      sbbs is actually installed.
      
      Note: this function is different than the one previously defined in getctrl.c
      but never used. If/when we ever really need to support PREFIX, then perhaps
      we'll use that one (which copies a string to a buffer).
      b236be71
  17. Feb 20, 2018
  18. Aug 22, 2015
  19. Oct 24, 2012
  20. Oct 29, 2011
    • deuce's avatar
      Fix format-related warnings. · 8563ad46
      deuce authored
      This is *likely* to break the Win32 build and even when the macros are
      specified in xpdev, I doubt Microsoft has added support for the 'z' size
      specifier used in smblib/smbadd.c we'll likely need a SIZE_T_SIZE macro
      that is "z" on C99 systems and "ll" or "64" or whatever it is on Win32.
      
      Or maybe a whole slew of complete SIZE_T macros since the 32/64 but thing
      and the max file size thing may actually need the full format specification
      to be in the macro... "zu" on C99 platforms and whatever magic Microsoft
      needs there.
      8563ad46
  21. Jun 04, 2008
  22. Feb 24, 2008
  23. Jul 08, 2007
  24. Dec 04, 2005
  25. Sep 20, 2005
  26. Sep 10, 2005
  27. Jul 11, 2003
  28. Apr 23, 2002
  29. Apr 12, 2002
  30. Mar 28, 2002
  31. Mar 13, 2002
  32. Feb 11, 2002
  33. Jun 15, 2001
  34. Nov 04, 2000
  35. Oct 21, 2000
Loading