As reported by Chris/akacastor (21:1/162), SyncTERM would always assume the
Telnet session was in ASCII mode until/unless conn_binary_mode_on() was called
which is only called at the beginning of a file transfer, which sets the
conn_api.binary_mode accordingly. Unfortunately, if the Telnet server
requested binary mode itself (e.g. during initial connection), SyncTERM would
(try to) set the connection back to ASCII mode after any file transfer. :-(

With this change, the conn_api.binary_mode will track the actual binary TX
mode whether initiated locally or remotely (by the server), but it'll only be
set to true when *both* directions are succesfully set to binary mode. And
this way, if the connection was already in binary mode before any file
transfer, it'll remain in binary mode as was apparently desired by the server.

Also with this change, we could probably remove the setting of
conn_api.binary_mode to true/false in conn_binary_mode_on()/off() functions,
but it shouldn't hurt anything if it's left there I suppose (in case some
*other* terminal transport protocols have the concept of binary mode?).

Found by MSVC warning

This should now display pretty normally on both 40 and 80 column displays.

"FreeBSD" is 7 chars, so make that the max expected platform name (for now).

Addresses issue #746, request from Nelgin

Fix a long standing bug where by sysops could page for chat or send node
messages or telegrams to any node, even if there wasn't a user even connected.

Regular users were not affected by this bug.

And use sizeof, not the magic number (again).

Deuce expanded the local 'error_code' buf to not trip the SAFECOPY macro
destionation buffer length check. Only this buffer needed to be 4 chars
exactly to truncate the 'message' string at 3 chars (e.g. just "404" for an
error message string that starts with "404 "). Switch from SAFECOPY to strlcpy
to eliminate this bug.

As reported by Ragnarok as part of issue #748

The web error files should work again.

Update to commit 85a2de04 (2 years ago).

FSC-74 specifies:
"The conference name shall be no more than 60 characters in length."

SCFG was limiting sub and dir area-tags to 40 chars and SBBSecho was limiting
area tags to 50 chars in length.

FSC-74 isn't a standard, but lacking this detail in FTS-4 and considering it
comes from the same authoritative source (the Conference Mail System User
Manual), I think it's the best source of truth we have.

Also, since we're no longer using .cnf files, we don't need different max
area-tag lengths between SBBSecho and SCFG structs - they all now use the same
macro: FIDO_AREATAG_LEN

Increase ansicode[] buffer size from 20 to 200 bytes due to this observed
crash when attempting to load an ANS file saved from PabloDraw:

As reported by Fzf (FQBBS):

It addresses the local configuration but unfortunately it still doesn't set
remote options.  The remote is usually going to be in binary mode but SVDM has
the remote option set to ASCII by default.  A CR from the remote then gets held
up until a second byte is sent.

Also suggested by Fzf, when server_binary mode is not configured, then advertise
and request binary mode is/be disabled, explicitly.

We're just using it to "fix" the case, if the file indeed exists.

If client socket is connected, wait up to the specified timeout period (in ms)
for the output buffer to be emptied.

This is much preferred over blindly calling mswait() after sending some data
(e.g. a file) and possibly waiting much longer than necessary.

Since the Terminal Server is a single thread, let's not block for long
periods of time trying to send bytes to a client (e.g. send the badip.msg
file contents to a client with a blocked IP address), effectively DoSing the
terminal server.

This should address the problem reported via IRC:
<theviper4> │Apr  9 15:38:11 viper-bbs synchronet: term Terminal Server timeout(outcom) 0000 0000
<theviper4> │Apr  9 15:38:35 viper-bbs synchronet: term Terminal Server !ERROR 110 sending on socket 39
<theviper4> │Apr  9 15:38:35 viper-bbs synchronet: term Terminal Server !ERROR 32 sending on socket 39
<theviper4> │Apr  9 15:38:35 viper-bbs synchronet: term Terminal Server !ERROR 32 sending on socket 39
<theviper4> │Apr  9 15:38:36 viper-bbs synchronet: term 0039 Telnet !CLIENT BLOCKED in ip.can: 117.95.153.33

Also, make the outcom timeout error message more helpful (e.g. include the
sock descriptor of the client) and don't use the old rioctl() function
here any more.

yes, this is a Y2K38 (or Y2106) issue, but we should have that worked out
when upgrading to the next libmozjs.

Need something like NUMBER_TO_JSVAL() and equivalent LAZY_NUMBER macro that
can deal with >32-bit ints correctly (or just always convert to double?).

... while the mods/*.bin command shell filenames could be any-case!

Only impacted non-Windows systems (UNIX file systems are case-sensitive).

Discovered while making this tutorial video: https://youtu.be/HlwQ0uX4S04

This is the time_t (seconds since Unix epoch, Jan-1-1970 UTC) date/time of the
current (most recent) Git commit used to build the running binary.

If a JS developer wants to check if a build is recent-enough to include some
change, this is the property they should use to check (with >= comparison).

This solves the problem of exit() values (e.g. non-zero return codes) not
getting propagated to callers when nest-called (e.g. via bbs.exec()).

I think it was kk4qbn that pointed this out via IRC: an exit(1) call from
prextrn.js did not stop the external program from running (as it should, for
any non-zero exit code). This only happened when the prextrn.js called another
JS script (e.g. via bbs.exec() or as was the case here, indirectly via "EXEC"
@-code in the YesNoBar text.dat string (which executed yesnobar.js). This
nested JS script invocation via sbbs_t::js_execfile() would clobber the stored
js.scope property value (where the "exit_code" property is written).

Script invoked in their own context (e.g. via js.exec()) wouldn't have this
issue in the first place.

A QWKnet tagline usually contains CP437 character 254 and if/when appended to
a message during export, would "convert" the message to CP437 thus making the
"ASCII" charset advertisement incorrect.

If a FIDO CHARSET value was already specified (e.g. in HEADERS.DAT), that
value will (still) not be overridden. So the *original* import via QWK (before
it gets exported to a QWKnet) is where this change will take effect.

Fix for issue #741

When invoking a nested JS script, these properties of the "js" object would
be overwritten and not restored, as discovered/reported by Nightfox when his
trivial game script would indirectly execute yesnobar.js, his subsequent use
of js.exec_dir would point to the wrong location (the "exec" directory, parent
of yesnobar.js, and not the direcctory where his game script was located).
The exec_path and exec_file properties had the same problem as demonstrated
by a simple test.js placed in (and executed from) a directory other than the
"exec" dir:
	function f() {
        print("js.exec_path = " + js.exec_path);
        print("js.exec_dir = " + js.exec_dir);
        print("Js.exec_file = " + js.exec_file);
	}
	f();
	console.yesno("test");
	f();

This would only trigger the problem when executed from the BBS and whebn the
YesNoQuestion text.dat string invokes the "yesnobar" module via EXEC @-code and
yesnobar.js exists (in exec or mods dir), superceding yesnobar.bin which does
not trigger this issue (not a JavaScript mod).

Hopefully fixes issue where certificate file is left open and so
can't be deleted.

Only two major chunks left... settings and connected mode!

- MainLoopDelay - in milliseconds
  Set this to a non-zero value to add some CPU yielding to the main loop
- SocketSelectTimeout - in milliseconds
  Set this to a non-zero value to add some CPU yielding while waiting for
  receive data from the TCP socket

These are 2 knobs created for Fzf (FQBBS) to "to reduce the CPU usage". Their
default values are currently 0, so you'll need to set these to non-zero values
to play with each of them and see their inpact on CPU utilization and
responsiveness. I'd suggest starting with low values (e.g. 1) and experimeting
from there.

Incremented version to 0.5

As requested by Fzf (FQBBS):

  When SVDM uses an inherited socket (the -h option) no telnet negotiations
  are done.  As a result, the connection is assumed to be in ASCII mode and
  server side CR characters are translated to CR/LF.  Since most programs are
  already transmitting a CR/LF this gets translated to CR/LF/LF with the
  expected results.  When using an external socket in telnet mode, could SVDM
  set the telnet.local_option and telnet.remote_option variables as so:

    A. Assume both remote and local have already suppressed GA and set the two
       options accordingly

    B. Set the remote telnet echo option to off and set the local telnet echo
       to follow the ServerEcho option from the .INI file

    C. Set both remote and local BINARY_TX options to follow the ServerBinary
       option from the .INI file

The big remaining issue is defining *_EXPORTS where needed, which
looks rough from a quick glance.

There's only one toggle left (Leave node file open) and not very many advanced
options.

Unfortuantely, can't easily do the cool left-right cycle through nodes since
each node file has to be saved/loaded, but still, easier to visualize any
differences between node configs with all the settings on one menu.

From SCFG->Nodes ... Toggle Options to SCFG->System->Toggle Options

And from a bit flag in node_misc to its own bool member of scfg_t.

The way this option worked was, if enabled (and it was off by default), bit 7
of all character input *before* successful logon would be stripped and bit 7
from all character input of terminals configured as US-ASCII (only) would be
stripped after logon.

Instead, always strip bit 7 (the 8th bit) of each input character from US-ASCII
(only) terminals. Other detected/configured terminals (CP437, UTF-8, PETSCII)
won't have bit 7 stripped (ever) since that's likely not a necessary or nice
thing to do. There's now no different handling of pre/post logon in this
regard.

If there's a need to strip parity bits from character input from client
terminals that support CP437, UTF-8, or PETSCII, then we'll re-add this feature
in but it shouldn't be a per-node setting in that case.