Insert an optional boolean argument to enable a search through deleted and
inactive user records (in addition to active user records). This is part of
the solution to the problem described in issue #513 where the UEDIT sysop
command did not go to a specified user (by alias) automatically, presumably
because the user record was marked as deleted.

Some trailing whitespace clean-up too.

Previously, many servers and services didn't support login by real name
(e.g. issue #469) even if the sysop had that option enabled in SCFG.

Move login control settings from node.ini to system (main.ini -> login)

The 3 node toggle options:
- Allow Login by User Number
- Allow Login by Real Name
- Always Prompt for Password

... have been now moved from SCFG->Nodes->Node x->Toggle Options to
SCFG-System->Toggle Options.

If you upgraded to v3.20a before now, you'll want to double-check these
settings to make sure they're how you want them set. New upgraders that run
upgrade_to_v320.js (e.g. via 'jsexec update') will get these settings migrated
automatically.

Added some error detection/logging to upgrade_to_v320.js when failing to open
.cnf files.

Constified some more user/login related function args and return types.

<host>/error
.../spam
.../hack

Yeah, the Windows block doesn't some unsafe concatenations still.

This should be used elsewhere too.

Also resolved some 32 vs 64-bit 'long' issues/ambiguities that have long-remained. :-)

This commit also removes logon.lst file support.

There's a TODO block remaining in js_user.c for setting portions of a user's birthdate (e.g. just the year or month or day).

*/dsts.dab (daily statistics and running totals) -> */dsts.ini
*/csts.dab (cumulative statistics / log) -> */csts.tab

* dsts.ini now has both daily and total stats for all fields (not just timeon and logons).
* dsts.ini is now an easily modifiable text file - no longer need dstsedit (here-by deprecated and soon to be deleted)
* dsts.ini and csts.tab support 64-bit upload/download byte stats and are very extensible for future fields to be added or extended > 32-bit (this was the main inspiration for this overhaul, but it was overdue and already designed for v4, pretty much)
* csts.tab is a tab-delimited fixed length record format suitable for easy import to a spreadsheet program or parsing with scripts. Each day is a 128-character LF-delimited record with tab-delimited fields of plain ASCII text.
* All fields except timeon in dsts.ini files are updated immediately and by more non-terminal servers (e.g. post statistics from web UI scripts).
* New user stats are tracked more than just for "today".

The upgrade of these files is automatic and built-into SBBS.

Still to do: overhaul the slog utility to support the new csts.tab file format.

Resolves issue with filelist.js trying to pass 4294967295 (-1) to system.datestr() resulting in:
!JavaScript  /sbbs/exec/filelist.js line 13: Error: can't convert t to an integer

system.illegal_filename() - check if contains illegal chars/sequences
system.safest_filename() - check if contains only safest chars
system.allowed_filename() - check if meets criteria from SCFG->File Options
system.check_filename() - check if legal and meets configured criteria and is not in file.can
bbs.check_filename() - ditto, except will display badfile.msg as appropriate

Now scripts can utilize the sysop-controlled filename criteria and security of the BBS.

This variable tracks the time that jsdoor was started.

Previously, these both used gettimeofday() which is both expensive
to call, and not monotonic.

This fixes system.clock_ticks in JS and various internal bits. for
when the UTC wall clock jumps.

While we're here, fix the documention of system.clock_ticks

This macro has expanded to nothing for a while now and even before, the usage was misguided and unnecessary as explained in this video: https://www.youtube.com/watch?v=cjotPqQxxAY

CID 319143

This appears to work and the event handler *should* work on other
event types already.

Note, this is *nix-only due to the use of poll().  select() will
need to be used for Windows to keep XP compatability.

Hopefully not introducing any bugs in the process.

Hopefully not introducing any bugs in the process.

The first argument can now optionally be an array of strings (e.g. as read from File.readAll()), so that multiple searches of the same file (e.g. twitlist.cfg, while importing messages) does not require multiple *reads* of the same file.

New @-codes: GIT_HASH and GIT_BRANCH
New JS system properties: git_hash and git_branch

When system.new_user() was called but the current "client" object is uninitialized (e.g. has NULL protocol, host or IP address fields because there is no active client, e.g. because is was called from a timed event with active user online) - this code would dereference a NULL pointer and crash the b0rad. Reported by Mortifis.

Like bbs.text(), except the "system" object is more widely available (e.g. in JSexec, mail server, web server, services) - in case any text.dat strings are useful in those execution environments tool. Requested by mlong.

Also cleaned up the argument validation in some of these other system methods (throw useful error exceptions rather than just returning false).

betwen 4 (the default) and 40 (the maximum) characters

- JS system.operator_available property (read/writeable)
- SYSAVAIL @-code which expands to LiSysopAvailable or LiSysopNotAvailable
  (use the new SYSAVAIL @-code in the chat menu to show availabilty to chat)
- ;avail sysop command (in str_cmds.js) to toggle sysop availability
- Changed LiSysopIs text.dat string to be a format string (include %s) and
  the trailing \r\n, so that it can be used in str_cmds.js or anywhere else
  to report sysop availability to chat, or can be set to blank string to
  display nothing (this would not work previously).

- min_password_length (currently hard-coded to 4)
- max_password_length (currently hard-coded to 40)

Remove 2 unused system properties (nobody uses PostLink/UTI drivers any more):
- psname
- psnum

use this in place of system.node_list[] if you're going to be using a lot of
the properties and passing them around to methods which are going to each
possibly dereference the values, as *each* deference results in a read of the
node record in the node.dab. On my system, a simple node list (e.g. /L
command) would result in between 60 and 100 reads of the node.dab (for a 13
node system), which was nuts.

The system.get_node() method currently leaves the node record unlocked and
there is currently no equivalent put_node() method, so you still need to use
the system.node_list[] for modification of node records. But, I now see there
are race conditions with the current methods of read-modify-writes of the
node_list[] properties. We should be locking a node.dab record, reading it,
modifying it, writing it, and then unlocking it - as is done in the C/C++
code. So... that's a todo item.

Also created system.stats.node_gets to track the number of node.dab reads
from a single instance of the system object. May remove this any time.

"getter".
Don't call getstats() when querying properties that aren't actually
stats (e.g. total_users) - performance optimization.

The scfg_t instances are often shared between threads and we can't really share
file descriptors between threads, so we ended up with file descriptor leaks and
race conditions.

Instead, define/allocate/free a new js_system_private_t where the scfg_t* and
the nodefile (descriptor) are kept - per "system" instance.

(ctrl/node.dab) is constantly closed and re-opened for every non-locking read.
This is really slow across network file systems and unnecessary, so use a
similar optimization as the C++ sbbs_t class where the file can (and normally
is) left open across multiple consecutive reads.
Create/use opennodedat() function.
Uses the new CLOSE_OPEN_FILE() macro from xpdev/filewrap.h.