A bunch of possible (but often, not really) use of undefined values.
Some ignored return values (e.g. of chsize/ftruncate, read, write, fgets).

Other than some added diagnostics upon some of these unexpected syscall
failures, there should be no change in behavior from this commit.

The format string used did not insure there was any space between fields leading to very hard to parse stats, like this:
User          2  SSH      12:25 12:39  14554  0  0  0  0  0

That's 554 msgs read in 14 minutes online, but well, you see what I'm say'n.

Mostly [s]printf format fixups

After the move to 64-bit upload/download byte counts, these integers are different width than 'long' on 32-bit builds (e.g. Windows), so these numbers were wrong on all but 64-bit *nix builds.

The change here also uses the cool byte_estimate_to_str() function so that large byte totals are not expressed in 'K' but rather 'M', 'G', 'T' etc. suffixes.

The formatting is otherwise consistent with the pre-existing log line format save for the use of an uppercase suffix now.

Before:
@- 02:19p  T: 12   R:  0   P:  0   E:  0   F:  0   U:  0k 0   D:420k 1
After:
@- 02:07p  T:  0   R:  0   P:  0   E:  0   F:  0   U:  0K 0   D:420K 1

Before:
@- 02:23p  T:  0   R:  0   P:  0   E:  0   F:  0   U:  0k 0   D:1359k 1
After:
@- 02:26p  T:  1   R:  0   P:  0   E:  0   F:  0   U:  0K 0   D:1.3M 1

This fixes issue #519. I'm glad to hear that sysops still use these log files!

- Most published messages (besides log entries) have a timestamp (in ISO8601 format) prepended and tab-separated
- The order and number of elements in client messages (list and activities) has been updated, now includes user number
- Server client lists are now published to .../SERVER/client/list
- Server client activities (connect, disconnect, update) are now published to .../SERVER/client/action/#
- Server client count is now published to .../SERVER/client (with the maximum client count, if applicable)
- Server states are now just represented by name (e.g. initializing, ready, stopping, stopped) and not number
- BBS errors are logged to sbbs/BBS/action/error/LEVEL (where LEVEL is the log level name, e.g. "critical" or "error')
- All server hack-attempts, SPAM attempts, logins, logouts, uploads, downloads, are published to sbbs/BBS/action/ACTION/*
- Chat pages are published to sbbs/BBS/action/page/node/#
- New users (on the terminal server) are published to sbbs/BBS/action/newuser
- Posted messages and executed external programs (on the terminal server) are published to sbbs/BBS/action/ACTION/CODE topic
- The event thread started/stopped status is published to .../SERVER/event

Yeah, the wiki will get updated soon to reflect/document all these changes

... for proper error reporting, at least in the terminal server.

Also define/use a macro for the user base filename (now user.tab, not user.dat).

Also resolved some 32 vs 64-bit 'long' issues/ambiguities that have long-remained. :-)

This commit also removes logon.lst file support.

There's a TODO block remaining in js_user.c for setting portions of a user's birthdate (e.g. just the year or month or day).

Fixed typo in another comment

There was a bug with reloading the configuration files in sbbsctrl where the sound button no longer reflected the truth and the sysop's previous click-state of the button was lost. Rather than going through writing the OPT_MUTE flag to the Options fields of all the sections of the sbbs.ini and then re-loading that file as a result, just do like we did with the sysop chat availability: use a semfile. So much simpler.

If anyone ever needs instance-specific muting, we can create/check instance/host-specific mute semfiles then. Doubt that'll happen though.

Also, removed the old sysavail control methods of ntsvcs too.

A "hack attempt" sound file is now supported in the Terminal Server, Mail Server,  and Services.

"login" and "logoff" sound files are now supported in the Terminal Server, FTP Server, Web Server, Mail Server, and Services.
This enhancement fixes Issue #157

The following sound files may now be configured in the [Global] section of the ctrl/sbbs.ini file, if desired to set the default sound files for all servers/services in on place:
- AnswerSound
- LoginSound
- LogoutSound
- HangupSound
- HackAttemptSound

This won't impact Synchronet as it has a separate signal handling
thread, but we still need to behave properly for processes that
don't.  I'm also saying that ENOMEM does not indicate a disconnection,
though it may be better to pretend it was disconnected...

This reverts commit 9fd06985.

ERROR 2 (No such file or directory) in logout.cpp line 189 (backout) opening "/sbbs/node1/backout.dab"

(when/what is executed, or at least attempted).

is set: this insures that uninitialized msg-scan ptrs/cfg won't be
written to disk unless a successful logon()/getmsgptrs() was called first.
This probably fixes the sighting that echicken reported where a failed
SSH login caused his sub-scan config file (data/user/0001.subs) to contain
uninitialized/garbage values.
logout() could be called from multiple places (e.g. JS and Baja modules),
even before a successful login is completed, so this sighting is not
entirely impractical.

("Node X", user alias, etc.) - so removing a lot of the redundancies.
Also, logging the current timed event code and other prefixes in the
event thread log messages - something I've wanted for a while now.
There might be some redundant "Node X" strings, so if you see some funny
looking log message, please let me know.

after a user (has been) disconnected and before the node transitions to waiting
for connection (WFC) status. Usually the duration of this status is very short,
but it can be longer (e.g. for running log-out module and event) and for (new)
msg-scan pointer fix-ups.
Updated logout() to remove some cruft and add some more log/debug output.
Automatic new-scan pointer fix-ups when performing new-message scans (if the
current pointer is greater than the last message number, set it to the last
message number) and when saving message pointers.
Passing user_t* to get/putmsgptrs() instead of message number now (to better
detect Guest account).

all exported functions and data types using a 32-bit time_t (time32_t).
(part 2 of 2)

inserting (long) typedefs to prevent warnings, but in the case of the JS File()
class, actually supporting file lengths > 32-bit.

passed 0 for the length.

module (.js or .bin) files.

variants (gmtime_r, localtime_r, and ctime_r) for thread-safe operation on Unix

outside the sbbs_t class).

GMT/UTC.