So Clang-FreeBSD was warning (in compiles of scfg/scfg*.c by Deuce):
result of comparison of constant 100000 with expression of type 'uint16_t'
(aka 'unsigned short') is always true

Why? Cause a uint16_t's max value is 65535 (less than 100000). Sure we could
have just lowered the UIFC max number of config items to 65535, but that would
have been too easy. And why are these compared-with values of type uint16_t to
begin with? Because most ctrl/*.cnf lists (of configuration items) were
limited to 65535 entries cause ... 16-bit DOS, historically. Now that *.cnf
files aren't used, we could just increase these scfg_t.*_total type sizes from
16 to 32-bits, yeah? The result is this commit.

I went to (signed) int so we could still keep -1 as the special illegal
sub/dir num value (e.g. INVALID_SUB, which is sometimes used to indicate the
email message base). Theoretically, 2 billion configuration items could be
supported in these lists, but SCFG will limit you to 100000 anyway. So there's
a whole lot of s/uint/int in this commit.

I'd be very surprised if this doesn't result in some new GCC/Clang warnings,
but at least the old "comparison of constant 100000" warnings are now gone!

Fix bad and poor unicode mappings, add support for sending Insert
and Pipe.

Toggled using backtick.
Current state is shown in the status bar.

Since we previously couldn't actually *show* the status bar in
ATASCII (or C64) mode, enable that as well.  This means supporting
40-column status bars too.

We still default status bar to off for those modes, because that's
likely what people actually want.

Also, it seems ENTER was broken in ATASCII mode, so fix that as well.
Implements SF feature 61

Save the window position and size when we enter fullscreen, and
restore when we leave... this was a bigger box of worms than
expected since we can get ConfigureNotify events that tell is
"Something" changed, but not be able to know the current window
position.

Just remove the x_get_window_info() and anything else that cares
about the window position and derive it from the ALT-Enter keypress
instead.

At the same time, try to remove as much special-casing for
fullscreen as possible.

Tested under marco and xfwm4... will test under Sommelier "soon"

May fix #564, may not, nobody knows.

When using the marco WM, and resizing using ALT-Right-drag, calls to
SDL_SetWindowMinimumSize() result in the top-left corner of the
window moving up and to the left (appears to be by the border size).

To prevent this from being a maddening issue under marco, ensure
we only call SDL_SetWindowMinimumSize() once when the minimum size
changes on the window.

Fixes SF ticket 115, thanks Ragnarok!

While we're hear, ensure the minimium maximum window size holds
the original sized window... we're not interested in downscaling.

Don't always start with _NET_WM_STATE containing
_NET_WM_STATE_FULLSCREEN

Enable PropertyChange events

Adjust x_cvstat.win* when _NET_WM_STATE gets
_NET_WM_STATE_FULLSCREEN added

Don't disable fullscreen in ConfigureNotify handler when
fullscreen is still pending

Now that I've upgraded my RPi 400 to aarch64, it turns out aarch64
isn't supported by Spidermoney or the libffi it ships with, so
there's no easy way to make it build.

Untill Spidermonkey is updated, there's just no reasonable way to
build on aarch64.

On expose, always redraw the entire screen.  The calculations were
wrong and with fractional scaling, some of them will always be wrong.

Don't clear the screen when xim is resized.

It looks like "armv7l" didn't exist when this version of Spidermoney
was released.  Just expand a previous patch to include all arm*
architectures.

C allows char* p = '\0' (which is clearly wrong)
C++ does not.

format specifies type 'unsigned short' but the argument has type 'unsigned int'

"unary minus operator applied to unsigned type, result still unsigned"

Even though this same code compiled and worked as expected with GCC.

SANITIZE is not fully supported (or recommended) yet.

FORTIFY will include some performance hits, but those might be offset by -O1
(which is apparently required for _FORTIFY_SOURCE to have any effect).
Prevviosly, DEBUG builds used (implicit -O0).
I'm building and running sbbs on Vertrauen (git.synchro.net) now with FORTIFY.

Set FORTIFY=1 in your localdefs.mk if you wish to have this build option
enabled persistently.

I'm doing builds for my jail (which doesn't have libmosquitto) on
my system that does have it now, so I need to disable it manually.

Mostly (all?) about unchecked return values. Unexpected failures to read or
write some files could've definitely led to some weird bugs.

Don't null-deref h_addr_list.
Return in_addr_t instead of u_long.

warning: ‘maxval’ may be used uninitialized
warning: ‘inch’ may be used uninitialized

Don't deref a null pointer and return an in_addr_t instead of ulong.

Was wrong and therefore causing flickering.

Was not using struts, and was scaling to window size, not aspect
ratio size.

Also, reset struts when not in fullscreen mode.