When invoking a nested JS script, these properties of the "js" object would
be overwritten and not restored, as discovered/reported by Nightfox when his
trivial game script would indirectly execute yesnobar.js, his subsequent use
of js.exec_dir would point to the wrong location (the "exec" directory, parent
of yesnobar.js, and not the direcctory where his game script was located).
The exec_path and exec_file properties had the same problem as demonstrated
by a simple test.js placed in (and executed from) a directory other than the
"exec" dir:
	function f() {
        print("js.exec_path = " + js.exec_path);
        print("js.exec_dir = " + js.exec_dir);
        print("Js.exec_file = " + js.exec_file);
	}
	f();
	console.yesno("test");
	f();

This would only trigger the problem when executed from the BBS and whebn the
YesNoQuestion text.dat string invokes the "yesnobar" module via EXEC @-code and
yesnobar.js exists (in exec or mods dir), superceding yesnobar.bin which does
not trigger this issue (not a JavaScript mod).

Good Time Trivia: Make a copy of js.exec_dir on startup and use the copy, since js.exec_dir could change indirectly (i.e., console.yesno() running yesnobar.js in sbbs/exec)

See merge request !430

Eric Oulashin authored 11 months ago and Rob Swindell committed 11 months ago

Good Time Trivia: Make a copy of js.exec_dir on startup and use the copy, since js.exec_dir could change indirectly (i.e., console.yesno() running yesnobar.js in sbbs/exec)

Hopefully fixes issue where certificate file is left open and so
can't be deleted.

Renamed output file setup.exe to install_SBBS_v*.exe because InnoSetup
Warning: Setting the [Setup] section "OutputBaseFileName" to "setup" is not
recommended, all executables named "setup.exe" are shimmed by Windows
application compatibility to load additional DLLs, such as version.dll. These
DLLs are loaded unsafely by Windows and can be hijacked. Use a different name,
for example "mysetup".

Only two major chunks left... settings and connected mode!

Good Time Trivia: Formatting fix for sysop menu when the server scores file is missing. Allow showing help when playing a game by entering ?

See merge request !429

Good Time Trivia: Formatting fix for sysop menu when the server scores file is missing. Allow showing help when playing a game by entering ?

- MainLoopDelay - in milliseconds
  Set this to a non-zero value to add some CPU yielding to the main loop
- SocketSelectTimeout - in milliseconds
  Set this to a non-zero value to add some CPU yielding while waiting for
  receive data from the TCP socket

These are 2 knobs created for Fzf (FQBBS) to "to reduce the CPU usage". Their
default values are currently 0, so you'll need to set these to non-zero values
to play with each of them and see their inpact on CPU utilization and
responsiveness. I'd suggest starting with low values (e.g. 1) and experimeting
from there.

Incremented version to 0.5

As requested by Fzf (FQBBS):

  When SVDM uses an inherited socket (the -h option) no telnet negotiations
  are done.  As a result, the connection is assumed to be in ASCII mode and
  server side CR characters are translated to CR/LF.  Since most programs are
  already transmitting a CR/LF this gets translated to CR/LF/LF with the
  expected results.  When using an external socket in telnet mode, could SVDM
  set the telnet.local_option and telnet.remote_option variables as so:

    A. Assume both remote and local have already suppressed GA and set the two
       options accordingly

    B. Set the remote telnet echo option to off and set the local telnet echo
       to follow the ServerEcho option from the .INI file

    C. Set both remote and local BINARY_TX options to follow the ServerBinary
       option from the .INI file

The last commit changed the environment, so we need to regenerate
the config cache.

The big remaining issue is defining *_EXPORTS where needed, which
looks rough from a quick glance.

There's only one toggle left (Leave node file open) and not very many advanced
options.

Unfortuantely, can't easily do the cool left-right cycle through nodes since
each node file has to be saved/loaded, but still, easier to visualize any
differences between node configs with all the settings on one menu.

From SCFG->Nodes ... Toggle Options to SCFG->System->Toggle Options

And from a bit flag in node_misc to its own bool member of scfg_t.

The way this option worked was, if enabled (and it was off by default), bit 7
of all character input *before* successful logon would be stripped and bit 7
from all character input of terminals configured as US-ASCII (only) would be
stripped after logon.

Instead, always strip bit 7 (the 8th bit) of each input character from US-ASCII
(only) terminals. Other detected/configured terminals (CP437, UTF-8, PETSCII)
won't have bit 7 stripped (ever) since that's likely not a necessary or nice
thing to do. There's now no different handling of pre/post logon in this
regard.

If there's a need to strip parity bits from character input from client
terminals that support CP437, UTF-8, or PETSCII, then we'll re-add this feature
in but it shouldn't be a per-node setting in that case.

The configure script was using uname -m as the build platform, but
Bullseye on RPi uses a 64-bit kernel (aarch64 uname -m) with a 32-bit
userland (arm gcc build host), which resulted in a lot of bad decsions
around JIT stuff.

With this change, we explicitly pass the build/host/target values as
taken from the compilers in question, which fixes the issue for Bullseye
(But may break mingw32?  Well we'll see how the pipes go).

4-bytes is how bit a 32-bit pointer is.

This works on Buster at least... update the other config.guess file
the same as the top-level one, and always define JaegerSpew() so the
JIT stuff isn't broken.

Yeah, it's getting about that time...

Addresses issue reported by Dumas Walker (CAPCITY2) and kk4qbn (KK4QBN)
whereby the list contains filenames in the wrong case.

As I said, untested.