... using snprintf() instead of sprintf()

Since we are now free()ing the opt[] items in bail(), I've seen heap
corruption core dumps after navigating the SCFG menus with some long
configuration items (e.g. timed events with max-length command-lines).
This heap corruption has been present for a long, long time, but not
detected since we weren't free()ing these heap-allocated items.
Increasing MAX_OPLN would have been a mitigation for this issue, but
using snprintf(opt[n],MAX_OPLN,...) is the better fix.

The -strip option requires the (new to v3.20) strip_ctrl_a() method

Previously, when using the -all or -lib options, all directories would be
included in the filelist, but with the -user option, a valid user (e.g.
-user=guest, or -user=sysop) can be specfied to limit the scope of the list
to only directories accessible to the specified user (and downloads allowed
to the user as well).

The -utf8 option encodes all output in UTF-8 (instead of CP437) while the
-strip option strips any Ctrl-A (attribute) sequences from the output.

Copy/pasted (with little modification) from
https://synchro.net/docs/file_section.html#AdvancedOptions -> "Short Name:"

Some short names have specially predefined meaning and it's important to
include that detail here.

Unlike strip_ctrl(), does not remove any other control characters from string.

1) In savescreen(), if the vmode is not found, explicitly set
   pixels to NULL rather than leaving it uninitialized.
2) Ensure that currmode is never left as _ORIGMODE (which is not
   a defined mode, so can result in vmode not being found).

Caught/fixed by Deuce in Brookville, OH

the Subject CRC calculation was changed in May of 2022 (trailing whitespace is
removed prior to calculation), so messages imported before this date/revision
of sbbs might be detected as having an invalid/mismatch Subject CRC. This -S
option can be used to suppress such errors (for Keyop).

Don't support /option syntax any longer in non-*nix builds (just -options).
Options are now case-sensitive (i.e. -S and -s are different options).
Bump version to 3.20.

This is actually how sbbs v1/2 worked, before this functionality was moved to
chat_sec.src.

If the sysop doesn't want the prompt at all, just set the string
ChatWithGuruInsteadQ to blank in the ctrl/text.dat file (or copy this script
to mods dir and edit to your liking).

This resolves issue #569.

Although, Coverity is wrong, close() *can* "accept a negative number",
it just always returns EBADF... which would behave correctly.

Made a fix for the refactored theme config reading code in much of the Digital Distortion tools

See merge request !294

There's no good argument for this aside from "it feels more right".

It's gotten too crashy lately.

Properly initialize sixel mask width/height.
Free sx_mask->bits when finished.

These were broken by the PPM feature commit 6f97dfce

As Deon pointed out:

I saw that smbactive was removed recently (719b7523), but a quick search of
code, sees reminants in GNUmakefile and other files, which I'm wondering is a
cause of the problem...?

This mirrors commit 1dc4c22a about a year ago that optimized window
dragging, and performs basically the same check (removed a week ago
with commit a59aba35)

Now that bitmap_drv_request_some_pixels() just calls
bitmap_drv_request_pixels(), there's no point in calling expose_rect()
when ev->xexpose.count isn't zero.

- Only call cb_flush() if a new rect was queued.
- Ensure bitmap_drv_request_some_pixels() is only called once in
  response to an expose request.

This should fix issue #565.

Also, do not try to display frames where the scaled height or width
is less than the frame bitmap height or width.

sdl_getscaling() does not require vstatlock.  Move it out.

DD area choosers: Refactored/simplified the code for reading the configuration file

See merge request !292

DDFileLister: Theme configuration files can now just have the attribute characters without the control code. Refactored the code that reads the configuration.

See merge request !293

Eric Oulashin authored 1 year ago and Rob Swindell committed 1 year ago

DDFileLister: Theme configuration files can now just have the attribute characters without the control code. Refactored the code that reads the configuration.

SlyVote: Fix for error when quitting/aborting out of choosing a different sub-board. Refactored ReadConfigFile().

See merge request !291

DDMsgReader: Settings for being able to read deleted messages now apply to personal email (not just sub-boards), and not just appearing in the message list. (SCFG > Message Options > Users Can View Deleted Messages)

See merge request !290

Eric Oulashin authored 1 year ago and Rob Swindell committed 1 year ago

DDMsgReader: Settings for being able to read deleted messages now apply to personal email (not just sub-boards), and not just appearing in the message list. (SCFG > Message Options > Users Can View Deleted Messages)

SlyVote: Fix for error when quitting/aborting out of choosing a different sub-board. Refactored ReadConfigFile().

Currently useful only in GDI and SDL modes.  The external scaling
method is likely lower CPU utilization and may or may not look
better.

All bitmap drivers now support arbitrary scaling, and the scaling
factor is a double, allowing arbitrary window scaling in all bitmap
modes (making nelgin happy).

While we're here, fix bugs in horizontal interpolation and X window
resizeing.