I'm surprised more people haven't wondered aloud: why are all the Synchronet
server settings in this huge sbbs.ini file? Well... this kind of answers that
question: it's a hell of a lot of settings! And this isn't even everything
(several advanced/rarely-used/borderline-deprecated settings aren't included)!

As part of this change, I've replaced the old date/time display with the
current config file path/name that's being edited (more or less). This will
help when a sysop has multiple sbbs.*.ini files and makes it clear if you have
multiple sbbs installs (like me), which one you're editing at any given time.

I have not implemented any of the server setting edits (other than a couple
simple toggles) or help text yet and this does not detect changes or save them
to the sbbs.ini file, but I wanted to get this committed at this stage anyway.
If you're running sbbsctrl.exe (or maybe even gtkmonitor), then maybe this is
completely redundant and unnecessary, but I figured it was good to have these
settings in one edit find/edit platform-agnostic location anyway. Hoepfully
this will (when its done) make SBBS for *nix just that much easier for a newbie
sysop/sysadmin.

Since commit fd90eec6 (2 months ago), the Synchronet Web Server on
my Windows systems has occasionally gone into a state where every HTTP session
thread was causing 100% CPU utilization and each new HTTP session thread
would just exacerbate the problem eventually leading to complete system
instability/unresponsiveness until the sbbs instance was terminated. This was
more readily reproducible on a Win7-32 VM, but would occasionally, though
much less frequently, happen in a native instance on Win10-64 as well.

Using the VisualStudio debugger, I was able to narrow it down to this:

Each new HTTP thread (eventually, hundreds of such threads) would get stuck
in this loop in http_output_thread():

    while(session->socket!=INVALID_SOCKET) {

		/* Wait for something to output in the RingBuffer */
		if((avail=RingBufFull(obuf))==0) {	/* empty */
			if(WaitForEvent(obuf->data_event, 1000) != WAIT_OBJECT_0)
				continue;
			/* Check for spurious sem post... */
			if((avail=RingBufFull(obuf))==0)
				continue; // <--- data_event signaled, but never cleared
		}

There appears to be a race condition where this logic could be executed
immediately after the output ringbuf was created, but before writebuf() was
ever called (which would have actually placed data in the output buffer),
causing a potential high-utilization infinite loop: the data_event is signaled
but there is no data and the event is never reset and nothing can ever add
data to the ringbuf due to starvation of CPU cycles.

Uses of ringbuf's data_event elsewhere in Synchronet don't seem to be subject
to this issue since they always call RingBufRead after, which will clear the
data_event when the ringbuf is actually empty (no similar loops to this one).

The root cause just appears to be a simple copy/paste issue in the code added
to RingBufInit(): the preexisting 'empty_event' was initialized with a
correct initiate state of 'signaled' (because by default a ringbuf is empty)
but the newly added events (data_event and highwater_event) should *not* be
initially-signaled because... the ringbuf is empty. So I added some parameter
comments to these calls to CreateEvent() to hopefully make that more clear
and prevent similar mistakes in the future.

Relieved to have this one resolved finally.

DDMsgReader: Bug fix for deleting multiple selected messages

See merge request !271

This resolves the issue of the results of string commands not being visible
in novice menu mode. I don't see this issue when running default.bin.

┌────────────────────────····
│ Subj: nlog
│ Attr: Replied
│ To  : All
│ From: Greg Meckel (1:153/143)
│ Date: Wed Mar 22 2023 10:40 am UTC-9:00 (22.7 hours ago)
└───────────────────────────────────────────────······

I attempted to check my node log this morning using ;nlog but it only flashed
on the screen briefly and was gone. Do I possibly have something set wrong?

Fixed tagLineFilename capitalization error in SlyEdit_Misc.js. Fixes #538

Closes #538

See merge request !270

Fixes CID 451020

This was needed back in the v2 days to be sure the escape sequence was sent
*after* an output buffer before might've been cleared by a user's abort/Ctrl-C
action. SYNC/ASYNC called riosync() which called rioctl(TXSYNC) and we have no
equivalent in Synchronet for TCP/IP (modern sbbs). A user's Ctrl-C will clear
all pending I/O, but won't prevent subsequent output from being sent (until
the abort condition is cleared) as used to be the case with serial I/O.

... possible loss of data (yeah, yeah, we know)

This code will do nothing if there's no user logged-in or their terminal is
not ANSI or their terminal dimensions (rows and cols) are set to specific
values (not auto-detected). This code does the same thing as calling JS
console.getdimensions(). Since it waits (up to 5 seconds) for a CPR response
from the terminal, this does potentially slow down output, so caveat emptor.

This could be used by a sysop to address issue #529.

DD area choosers: Replaced hardcoded high-ascii single line character with a variable defining it via hex code (for the help screens)

See merge request !269

DD area choosers: Replaced hardcoded high-ascii single line character with a variable defining it via hex code (for the help screens)

The recently updated ctrl/sbbs.ini had MaxLoginInactivity = 10M in
the [BBS] section, which was parsed as 10 seconds rather than the
intended 10 minutes. This fixes that issue and also will now store all
of these inactivity values in duration notation. Existing values stored
in seconds will work fine since that is always the assumed/fallback unit
of time in duration keys.

Thanks for the report!

DD area chooser fixes for lightbar mode: Numeric input (for file area chooser) and wording changes on numeric input (for both)

See merge request !268

DD area chooser fixes for lightbar mode: Numeric input (for file area chooser) and wording changes on numeric input (for both)

And use putmsg() for strings that may have @-codes (e.g. ELLIPSIS)

The lower of the configured maximum file size (for the FTP server) and
the available disk space minus the configured minimum free disk space
is used as the maximum file size to allow upload. Appended files
are accounted for too.

Disallow uploads when free disk space falls below minimum configured
minimum free disk space.

This fixes issue #535

this insures that inactive dumb (bot) connections will be disconnected even
when using a script (e.g. animated pause prompt) that doesn't time-out.

Also, if the connected node is the last node (for this sbbs instance), divide
the socket inactivity timeout value in half.

These changes (along with sbbs v3.20) should help with DOS (denial-of-service,
not MS-DOS) prevention.

Mainly for Krueger.

- New keys in [BBS] section of sbbs.ini:
  MaxLoginInactivity (default: 10 minutes)
  MaxNewUserInactivity (default: 60 minutes)
  MaxSessionInactivity (default: none/unlimited)
- Each configured external program/door in SCFG can have its own maximum inactivity setting (or else the session max inactivity is applied)
- moved node-specific sec_hangup to system-wide/shared max_getkey_inactivity (configured in SCFG->System->Advanced)
- moved node-specific sec_warn (seconds of inactivity before sending warning) to inactivity_warn (a percentage of elapsed max inactivity before sending warning), also configured in SCFG->System->Advanced and used for both socket and getkey inactivity detection
- Renamed JS console.inactivity_hangup to console.max_getkey_inactivity (old name remains as alias)
- Renamed JS console.timeout to console.last_getkey_activity (old name remains as alias)
- Removed JS console.inactivity_warning
- Added JS console.max_socket_inactivity (current input_thread inactivity threshold)
- New text.dat string: InactivityAlert (just contains 3 ^G/BELLs by default) used for non-visual inactive-user warning

The MaxLoginInactivity setting in particular solves the problem of custom scripts (e.g. animated pause prompts) that just poll indefinitely for user input and never time-out  - these will no longer cause nodes to be tied-up with inactive/bot users at login.

You may ask yourself, how did I get here? No, you may ask yourself: why configure these socket inactivity max values in sbbs.ini? The reason is consistency: sbbs.ini is where the MaxInactivity is configured for all the other TCP servers and services.

This fixes issue #534 for Krueger in #synchronet

Instead of copy/pasta. No change in function,.

... to make property names more consistent (e.g. with bbs.last_node).
The old names (without the underscores) are still usable but won't appear
in JSDOCS (i.e. jsobjs.html).

This allows scripts (e.g. login.js) to have custom behavior (e.g. shortening
the maximum inactivity timeout) based on how close the current node is to the
configured last node number. There may be other uses too, but for the vast
majority of Synchronet systems, first_node will always be 1 and last_node the
same as system.nodes/lastnode. Ugh, inconsistent naming. :-(

Added a new configurable text string: scanningMessageText

See merge request !267

DDMsgReader: Makes use of console.aborted for proper screen updates after the user quits @ help screen pause. Shows sub-board status during a new message scan.

See merge request !266

Eric Oulashin authored 2 years ago and Rob Swindell committed 2 years ago

DDMsgReader: Makes use of console.aborted for proper screen updates after the user quits @ help screen pause. Shows sub-board status during a new message scan.

Add some missing descriptions, fix the order of others.

Mainly capitalization, but some typos and added details. 

This mimics default.src very closely, even the curious clear-screens before
the menu displays only when in non-expert mode (?).

I'll likely be using this to recreate some other command shells.

There's a couple of RIP-specific calls to getlines in default.src that I did
not port over (yet).

This commit fixes issue #526 for Nelgin (and any other JavaScript devs).

Note: this file supercedes default.bin, so beware if you have customized
default.src (and built your own custom default.bin), you'll want to move
those to your mods directory to continue to use them.

Another nail in Baja's coffin.

Use rmfiles() to recursively clean the temp dir, if available.

Don't count sub-directories (if somehow created) as files.

Clean the temp dir when exiting this module too.